Repository navigation
refactor: use mvr resolution from wallet-core - #53
Merged
Merged
Conversation
fcsondheim
changed the title
wallet-core
Coverage Report for @evefrontier/dapp-kit
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Resolve the dApp fallback and tenant configuration issues, and add the requested regression coverage.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR centralizes MVR resolution in wallet-core@0.0.13, updates tenant-aware type derivation, removes local MVR tooling, and adds an upgrade runbook.
Changes:
- Uses wallet-core’s shared MVR cache and tenant type resolution.
- Removes local cache, seeds, generator scripts, patch, and dependencies.
- Updates tests, package metadata, lockfile, and assembly behavior.
- Adds world upgrade documentation.
| File | Summary |
|---|---|
patches/@mysten%2Fmvr-static@0.4.17.patch |
Removes obsolete dependency patch. |
packages/libs/dapp-kit/utils/mvr/worldTypes.ts |
Uses wallet-core MVR resolution. |
packages/libs/dapp-kit/utils/mvr/worldTypeKeys.ts |
Removes local MVR seeds. |
packages/libs/dapp-kit/utils/mvr/README.md |
Removes obsolete local-cache documentation. |
packages/libs/dapp-kit/utils/mvr/mvrCache.generated.ts |
Removes generated local cache. |
packages/libs/dapp-kit/utils/mapping.ts |
Updates tenant type resolution; configuration checks require changes. |
packages/libs/dapp-kit/utils/index.ts |
Re-exports wallet-core type keys. |
packages/libs/dapp-kit/utils/__tests__/worldTypes.test.ts |
Updates shared-cache tests. |
packages/libs/dapp-kit/utils/__tests__/mapping.test.ts |
Updates mapping expectations; additional resolver coverage is needed. |
packages/libs/dapp-kit/utils/__tests__/constants.test.ts |
Updates currency package expectations. |
packages/libs/dapp-kit/package.json |
Updates wallet-core dependency and removes MVR tooling. |
packages/apps/assembly/src/components/Behaviour.tsx |
Updates dApp URL resolution; fallback handling requires changes. |
package.json |
Removes MVR patch registration. |
docs/world-upgrade-runbook.md |
Documents the MVR upgrade workflow. |
bun.lock |
Updates dependency resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@evefrontier/wallet-core(pinned to0.0.13) instead of keeping its own copy.getObjectIdandgetRegistryAddressbuild theObjectRegistryandTenantItemIdtype tags withgetTenantWorldType(tenant, key), instead of pastingTENANT_CONFIG[tenant].packageIdinto a string. Tenants not inTENANT_CONFIGstill fall back to the env-drivengetWorldType.gen:mvrscript,@mysten/mvr-static, and theenquirerpatch. Generation now happens only in wallet-core.docs/world-upgrade-runbook.md, which covers regenerating, publishing and pinning after a world or currency upgrade.Why
utopia resolved to
0xd12a70c…, a stale id hard-coded inTENANT_CONFIG, while its MVR tier (@evefrontier/world-uat) points to0x28eab6…. Regenerating the cache in dapp-kit couldn't fix this, because the tenant path never read that cache. wallet-core0.0.13gets tenant package ids from MVR, so both paths now use the same cache.Package ids that change (the
world-testtenants stay the same):0xd12a70c…→0x28eab6…0xf0446b…→0x5a575a…0x8b8a46…→0x7be18d…0xac361a…→0xc66365…0x28b497…→0x7be18d…0x2a66a8…→0xc66365…Screenshots / Gifs
n/a
Where has this been tested?