Redirect HTTP requests on HTTPS port - #3
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves Hatch’s HTTPS ingress behavior by redirecting plain HTTP sent to the published HTTPS port to the equivalent https:// URL (preserving host/port), and tightens runtime behavior/documentation around Chromium when running under no-new-privileges.
Changes:
- Add an nginx redirect for HTTP requests mistakenly sent to the HTTPS listener (nginx 497 → 301).
- Extend the Guacamole E2E script to validate the redirect behavior and to assert Chromium starts with
--test-typeunderno-new-privileges. - Update docs/PRD to describe the Chromium warning suppression behavior and capture the new redirect acceptance criterion.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/guacamole-config.sh | Adds nginx error_page 497 redirect to https://$http_host$request_uri. |
| scripts/e2e-guacamole.sh | Adds redirect validation and checks for Chromium --test-type in E2E. |
| config/chromium-launch.sh | Appends --test-type when NoNewPrivs: 1 is detected. |
| README.md | Documents --test-type being added under no-new-privileges. |
| INSTALL.md | Updates Chromium sandbox section to mention --test-type behavior. |
| PRD.md | Adds acceptance criteria for HTTP→HTTPS-on-HTTPS-port redirect and warning suppression. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests