Skip to content

Redirect HTTP requests on HTTPS port - #3

Merged
markcallen merged 2 commits into
mainfrom
redirect-http-to-https-port
Aug 26, 2026
Merged

Redirect HTTP requests on HTTPS port#3
markcallen merged 2 commits into
mainfrom
redirect-http-to-https-port

Conversation

@markcallen

Copy link
Copy Markdown
Contributor

Summary

  • redirect plain HTTP requests sent to the published HTTPS port back to the equivalent https:// URL while preserving host and port
  • add E2E coverage for the redirect behavior
  • add Chromium --test-type under no-new-privileges and document the warning suppression behavior

Tests

  • sh -n scripts/guacamole-config.sh
  • bash -n scripts/e2e-guacamole.sh
  • scripts/e2e-guacamole.sh

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves Hatch’s HTTPS ingress behavior by redirecting plain HTTP sent to the published HTTPS port to the equivalent https:// URL (preserving host/port), and tightens runtime behavior/documentation around Chromium when running under no-new-privileges.

Changes:

  • Add an nginx redirect for HTTP requests mistakenly sent to the HTTPS listener (nginx 497 → 301).
  • Extend the Guacamole E2E script to validate the redirect behavior and to assert Chromium starts with --test-type under no-new-privileges.
  • Update docs/PRD to describe the Chromium warning suppression behavior and capture the new redirect acceptance criterion.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/guacamole-config.sh Adds nginx error_page 497 redirect to https://$http_host$request_uri.
scripts/e2e-guacamole.sh Adds redirect validation and checks for Chromium --test-type in E2E.
config/chromium-launch.sh Appends --test-type when NoNewPrivs: 1 is detected.
README.md Documents --test-type being added under no-new-privileges.
INSTALL.md Updates Chromium sandbox section to mention --test-type behavior.
PRD.md Adds acceptance criteria for HTTP→HTTPS-on-HTTPS-port redirect and warning suppression.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/e2e-guacamole.sh Outdated
Comment thread scripts/e2e-guacamole.sh Outdated
@markcallen
markcallen merged commit 34996a1 into main Aug 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants