Add Mac shortcut mapping for Guacamole desktop - #4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an opt-out Mac-style shortcut bridge for the Guacamole-hosted desktop so common “Cmd/Super + key” shortcuts behave like Linux “Ctrl + key” shortcuts inside Chromium.
Changes:
- Introduces
HATCH_MAC_SHORTCUTS(default1) and propagates it through startup/env examples and Docker Compose. - Installs
xbindkeys+xdotooland starts a per-session keybinding bridge in the XRDP window manager startup. - Documents the new setting across README/INSTALL and updates the PRD requirement statement.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/entrypoint.sh | Exports HATCH_MAC_SHORTCUTS so it’s available to supervised services/sessions. |
| config/startwm.sh | Adds per-session xbindkeys config to map Mod4/Super shortcuts to Ctrl shortcuts via xdotool. |
| Dockerfile | Sets default HATCH_MAC_SHORTCUTS=1 and installs xbindkeys/xdotool. |
| docker-compose.yml | Adds HATCH_MAC_SHORTCUTS with default 1 to compose environment. |
| .env.example | Documents and exposes HATCH_MAC_SHORTCUTS in the example env file. |
| README.md | Documents HATCH_MAC_SHORTCUTS behavior and includes it in the env block. |
| INSTALL.md | Documents HATCH_MAC_SHORTCUTS behavior and includes it in the env block. |
| PRD.md | Adds shortcut-bridge behavior as a stated product requirement with opt-out. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HATCH_MAC_SHORTCUTS, defaulting to1, to enable Mac-style shortcut mapping in the remote desktopxbindkeysandxdotooland start a per-session mapping from remoteMod4shortcuts to LinuxCtrlshortcutsValidation
sh -n config/startwm.shsh -n scripts/entrypoint.shgit diff --checkdocker build -t hatch:mac-shortcuts-test .docker run --rm hatch:mac-shortcuts-test ...confirmedHATCH_MAC_SHORTCUTS=1,xbindkeys, andxdotoolare presentNotes