Repository navigation
Image viewer: a tap beside a zoomed image closes it - #149
Merged
Merged
Conversation
A tap closed the viewer only at the fitted size, so that a tap on a zoomed image would not throw it away; it caught the backdrop around a zoomed image too, where at the fitted size the same tap closes. A tap now closes at the fitted size anywhere, and zoomed in when it lands off the image as drawn. image-viewer-back.mjs --mobile zooms an image a little and taps beside it.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On touch, a tap closed the image viewer only at the fitted size, so that a tap on a zoomed image would not throw it away. That also swallowed a tap on the backdrop beside a zoomed image, where at the fitted size the same tap closes.
A tap on a zoomed image still does nothing; buttons and the open link keep their own taps; the mouse path is unchanged.
Evidence
tools/scenarios/image-viewer-back.mjs --mobilewith the new step:FAIL a tap beside a zoomed image closes it.After:
Merge Danger
Door: two-way
Blast Radius: image viewer
Touch closing only: a tap that lands off a zoomed image now closes it.