Repository navigation
Conversation
`experiment.failed_jobs()` (the failed / not-run job lists) overrode the
`BaseExperiment.failed_jobs` count property, so the web UI failed to list
a running experiment ("'>' not supported between instances of 'method'
and 'int'" in status_category) and the remote server sent a bound method.
The method is renamed `failed_jobs_by_reason()`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Pushed directly to master as bb28fee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
experiment.failed_jobs()(returning the(failed, not_run)job lists) overrides theBaseExperiment.failed_jobsproperty (the failed-job count). For a running experiment:Error handling message experiments: '>' not supported between instances of 'method' and 'int'(fromstatus_category,self.failed_jobs > 0);remote/server.py) sends a bound method asfailed_jobs.Seen with
experimaestro run-experiment --webon the demo, when loading the web page.Fix
Rename the method to
failed_jobs_by_reason()(callers:failure_summary,_report_failed_jobs,test_tasks), and add a test checking that the live experiment does not override thefailed_jobsproperty.🤖 Generated with Claude Code