[eas-build-job] Accept legacy command/path custom function shape in function.yml - #4095
Draft
sswrk wants to merge 1 commit into
Conversation
This was referenced Jul 27, 2026
Member
Author
This was referenced Jul 27, 2026
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
July 28, 2026 09:04
e893fae to
3b018d6
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
July 28, 2026 12:58
3b018d6 to
891ef23
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
July 28, 2026 13:11
891ef23 to
27f53d7
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
July 28, 2026 15:30
27f53d7 to
e8d69a0
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
July 29, 2026 09:01
e8d69a0 to
702bea2
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
2 times, most recently
from
July 29, 2026 13:40
961f32c to
9d5f159
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
July 30, 2026 15:09
9d5f159 to
36a1945
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
July 30, 2026 15:34
12c14b7 to
6118b1f
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
July 30, 2026 15:44
6118b1f to
3a694f5
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
2 times, most recently
from
July 31, 2026 10:06
69c604d to
ffbd85c
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
2 times, most recently
from
July 31, 2026 14:08
cd43f27 to
4a879c6
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
July 31, 2026 14:46
4a879c6 to
4ee8986
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
July 31, 2026 17:06
4ee8986 to
e0c8fb9
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
2 times, most recently
from
August 4, 2026 09:45
bb9bc43 to
6d2b4f2
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
4 times, most recently
from
August 4, 2026 13:46
b98bbfd to
a241370
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
August 4, 2026 14:16
a241370 to
d957ecb
Compare
sswrk
force-pushed
the
szymonswierk/eng-25402-eas-build-job-legacy-function-shape
branch
from
August 4, 2026 14:22
d957ecb to
ef13e90
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
🤖 AI code reviewDecision: Approve Overall PR risk: Medium. The change modifies existing behavior in local function config parsing and package exports. The affected surface is bounded to local function schemas, where callers can see new parse results or new rejection for mixed shapes. No specialist reviewer reported a warning or critical finding. No findings. This review is advisory — it never blocks a merge and never auto-approves. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## szymonswierk/eng-22387-eas-cli-validate-hook-composite-functions #4095 +/- ##
====================================================================================================
+ Coverage 62.42% 62.43% +0.02%
====================================================================================================
Files 1008 1010 +2
Lines 45712 45728 +16
Branches 9622 9622
====================================================================================================
+ Hits 28530 28546 +16
Misses 15721 15721
Partials 1461 1461 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
We want to grandfather the legacy reusable functions from custom builds (https://docs.expo.dev/custom-builds/functions/) into the new reusable functions that can be used in workflows. This is to make the migration from custom builds to workflows easier.
Currently, we only support composite functions. The first step towards extending the support is modifying the
eas-build-jobZod schema.How
legacyFunctionmodule with Zod schemas to match the legacy custom builds functions.LegacyCommandFunctionConfigZ(functions withcommand:present) andLegacyPathFunctionConfigZ(functions withpath:present).compositeFunctionand created a newlocalFunctionmodule with schema that is a union of composite function schema and legacy function schemas.Test Plan
Added unit tests.