Skip to content

[eas-cli] Add --name filter to simulator:list - #4118

Merged
szdziedzic merged 2 commits into
mainfrom
szdziedzic-claude/simulator-list-name-filter
Aug 4, 2026
Merged

[eas-cli] Add --name filter to simulator:list#4118
szdziedzic merged 2 commits into
mainfrom
szdziedzic-claude/simulator-list-name-filter

Conversation

@szdziedzic

@szdziedzic szdziedzic commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Why

Lets you filter eas simulator:list results by session name, next to the existing --status, --type, and --platform filters.

How

--name maps to the DeviceRunSessionFilterInput.name field added in expo/universe#29550, which does a case-insensitive prefix match server side. That change is deployed, so the regenerated schema picks the field up from production.

Test Plan

CI passes.

➜  testapp-staging git:(master) ✗ EXPO_STAGING=1 easd simulator:list --name szym --platform ios --type agent-device --status stopped
✔ Fetched 2 simulator session(s)

ID:       019fb30a-e913-72db-a3fc-7e864b3d81a5
Name:     Szymon's test
Type:     AGENT_DEVICE
Status:   STOPPED
Platform: IOS
Created:  4 days ago
URL:      https://staging.expo.dev/accounts/expo-services/projects/testapp-staging/simulator-sessions/019fb30a-e913-72db-a3fc-7e864b3d81a5

———

ID:       019fa856-b182-7f6b-805a-7e6ef00c4291
Name:     Szymon's test
Type:     AGENT_DEVICE
Status:   STOPPED
Platform: IOS
Created:  6 days ago
URL:      https://staging.expo.dev/accounts/expo-services/projects/testapp-staging/simulator-sessions/019fa856-b182-7f6b-805a-7e6ef00c4291

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.43%. Comparing base (5694370) to head (5832c11).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4118      +/-   ##
==========================================
+ Coverage   62.43%   62.43%   +0.01%     
==========================================
  Files        1009     1009              
  Lines       45735    45737       +2     
  Branches     9621     9622       +1     
==========================================
+ Hits        28548    28550       +2     
  Misses      15724    15724              
  Partials     1463     1463              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/simulator-list-name-filter branch from 7dcc9cd to d6351a3 Compare July 30, 2026 21:08
@brentvatne
brentvatne force-pushed the szdziedzic-claude/simulator-list-name-filter branch from 403690e to 4c386ce Compare July 30, 2026 23:01
@brentvatne brentvatne added the ai-review Commits pushed to PRs with this label be automatically reviewed. label Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

🤖 AI code review

Decision: Approve

Overall PR risk: Low. The change is additive and affects the hidden simulator list command filter path. The most plausible breakage is a server schema mismatch for the new filter field. No reviewer reported a warning or critical finding.

No findings.


This review is advisory — it never blocks a merge and never auto-approves.

@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/simulator-list-name-filter branch from 4c386ce to b60f69c Compare July 31, 2026 10:06
@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/simulator-list-name-filter branch from b60f69c to 5832c11 Compare August 3, 2026 16:55
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@szdziedzic
szdziedzic requested review from gwdp and sjchmiela August 3, 2026 16:58
@szdziedzic
szdziedzic marked this pull request as ready for review August 3, 2026 16:58
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@szdziedzic
szdziedzic merged commit eab32ec into main Aug 4, 2026
12 checks passed
@szdziedzic
szdziedzic deleted the szdziedzic-claude/simulator-list-name-filter branch August 4, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Commits pushed to PRs with this label be automatically reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants