[build-tools] label serve-sim metrics artifacts with the device name - #4127
Open
gwdp wants to merge 3 commits into
Open
[build-tools] label serve-sim metrics artifacts with the device name#4127gwdp wants to merge 3 commits into
gwdp wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4127 +/- ##
==========================================
+ Coverage 62.43% 62.43% +0.01%
==========================================
Files 1009 1009
Lines 45735 45738 +3
Branches 9621 9625 +4
==========================================
+ Hits 28548 28551 +3
Misses 15726 15726
Partials 1461 1461 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
marked this pull request as ready for review
July 31, 2026 22:13
szdziedzic
approved these changes
Aug 3, 2026
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We want to have a device name in the metrics file, since today it's just a hex users can't really make sense if multiple devices are used
How
Reads
deviceNamefrom the meta (serve-sim 'now' sends it: expo/serve-sim#37) and uses it for the artifact's display name. No-op until serve-sim ships it so we can roll this out independentlyTest Plan
CI passes w/ new unit tests