Skip to content

[build-tools] label serve-sim metrics artifacts with the device name - #4127

Open
gwdp wants to merge 3 commits into
mainfrom
gwdp/metrics-artifact-device-name
Open

[build-tools] label serve-sim metrics artifacts with the device name#4127
gwdp wants to merge 3 commits into
mainfrom
gwdp/metrics-artifact-device-name

Conversation

@gwdp

@gwdp gwdp commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Why

We want to have a device name in the metrics file, since today it's just a hex users can't really make sense if multiple devices are used

How

Reads deviceName from the meta (serve-sim 'now' sends it: expo/serve-sim#37) and uses it for the artifact's display name. No-op until serve-sim ships it so we can roll this out independently

Test Plan

CI passes w/ new unit tests

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.43%. Comparing base (cdf4e81) to head (c017c04).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4127      +/-   ##
==========================================
+ Coverage   62.43%   62.43%   +0.01%     
==========================================
  Files        1009     1009              
  Lines       45735    45738       +3     
  Branches     9621     9625       +4     
==========================================
+ Hits        28548    28551       +3     
  Misses      15726    15726              
  Partials     1461     1461              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp requested a review from szdziedzic July 31, 2026 22:13
@gwdp
gwdp marked this pull request as ready for review July 31, 2026 22:13
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants