[eas-cli] Set up TestFlight internal group when submitting with an existing ascAppId - #4136
Open
tchayen wants to merge 4 commits into
Open
[eas-cli] Set up TestFlight internal group when submitting with an existing ascAppId#4136tchayen wants to merge 4 commits into
tchayen wants to merge 4 commits into
Conversation
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
tchayen
added a commit
that referenced
this pull request
Aug 2, 2026
tchayen
added a commit
that referenced
this pull request
Aug 2, 2026
tchayen
force-pushed
the
tchayen/testflight-setup-existing-asc-app
branch
from
August 2, 2026 07:06
4e14402 to
de8a2e7
Compare
The automatic internal TestFlight group setup previously ran only when the CLI itself created the App Store Connect app during interactive submit. Apps created on the App Store Connect website (or submitted with ascAppId in the submit profile) never got a group, so processed builds sat in TestFlight with no one able to install them. eas submit now runs the same setup best-effort for existing apps, using strictly non-interactive App Store Connect API key auth (env vars or the EAS credentials service) and skipping silently when no key is available. The group regeneration prompt is skipped in non-interactive mode instead of hanging, the TestFlight group URL no longer hardcodes a foreign app id, and eas go now reuses the shared implementation instead of a duplicated copy. Claude-Session: https://claude.ai/code/session_0192qAxJXYhEtc91K1xRqNnk
tchayen
force-pushed
the
tchayen/testflight-setup-existing-asc-app
branch
from
August 2, 2026 10:44
de8a2e7 to
2a553d3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4136 +/- ##
==========================================
+ Coverage 62.40% 62.50% +0.11%
==========================================
Files 1009 1010 +1
Lines 45699 45708 +9
Branches 9615 9613 -2
==========================================
+ Hits 28513 28565 +52
+ Misses 15723 15691 -32
+ Partials 1463 1452 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The automatic TestFlight setup (internal group and admin testers) runs only on the interactive submit path that creates the App Store Connect app. Apps created on the ASC website never get a group, so processed builds sit in TestFlight with nobody able to install them.
How
eas submit -p iosruns the group setup best-effort whenascAppIdresolves from the submit profile. Auth is strictly non-interactive: an ASC API key from env vars or the EAS credentials service. Without a key the setup is skipped silently, so submits gain no new prompts or failures. apple-utils routes token-auth beta group and tester requests to the official ASC API, so no cookie session is needed.ensureTestFlightGroupExistsAsyncgains anonInteractiveoption that skips the destructive group-regeneration confirm with a warning.eas goreuses the shared implementation instead of its own copy.EAS_NO_AUTO_TESTFLIGHT_SETUPis respected on the new path.Test plan
CI passes. New unit tests cover the non-interactive behavior: no prompt, no group deletion, opt-out env var. The
IosSubmitCommandsuite asserts the setup runs for a profile-providedascAppId. Reproduced the original gap end to end while shipping a real app: an app created on the ASC website and submitted witheas build --auto-submit --non-interactivereached TestFlight with no internal group.