Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cap the permit-duration product at Long.MAX_VALUE before it can overflow. Tests check that an immediate request is rejected without consuming permits and that an unbounded reservation stays positive.
Fixes #404.
Validation: all 308 core tests passed on Java 11, including both new regressions. Core packaging also completed. Full
mvn verifystops in the OkHttp module atFailsafeCallTest.testCancel(expected IOException, received SocketException); the same test fails on unchanged upstreamed3f92739669. Retrofit tests were not reached.