improper setfile member now causes segfault - #95
Draft
mterenzi wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the ticket's agreed approach: a setfile line that can't be
stat()ed orloaded now aborts the reload, and
mtbl_fileset_init()returnsNULLwitherrnoset instead of coming up with a silently empty fileset.
Before / after, using an mtbl as a setfile:
Dumped 0 entries. (exit 0)Segmentation fault (exit 139)Three things worth considering:
dnstable doesn't check the NULL, so it segfaults in
mtbl_source_get_prefixrather than saying anything pointing the user to the real issue.
setfile_updated()commits the mtime before the reload runs(
libmy/my_fileset.c:63), so a failed reload records a revision it never appliedand the next call returns
true. Probably fine though?fs_load()assignserrnoafter the fact becausemtbl_reader_init()doesn'tset it on the not-an-mtbl paths. Works, but setting it at the source in
reader.cwould be more robust. That's a much bigger change than what the ticket needs though.