Repository navigation
Raycast: fix typed-market type error, type-check in CI - #20
Merged
Merged
Conversation
- Move contributor notes (AGENTS.md, Development, Releasing) out of raycast/ to docs/raycast.md - Drop the redundant command subtitle; declare macOS as the platform - Unique temp file per catalog write - A typed ^ ticker is an index, so the Indices filter keeps it - Retry action on the symbol-list failure toast; Show/Hide Chart in its own section Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYf7vdDtMHbY6YTKJrEqJ
- List rows: keep the rows that priced, and say which source failed with a Retry - A typed ticker with a known suffix (7203.T, 0700.HK) belongs to that market's filter - Validate catalog entries before replacing the copy in hand, with a malformed-export test - Use the hook's failureToastOptions instead of a hand-built toast - Copy Symbol is the second action, so it carries no custom shortcut Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYf7vdDtMHbY6YTKJrEqJ
…to claude/project-thread-k88liz # Conflicts: # raycast/src/search-symbol.tsx
ray publish updates the open Store submission only from the machine that holds its fork clone; a CI runner starts from scratch each time and replaced the submission PR (raycast/extensions#33095 -> #33098). Document the Mac mini command instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYf7vdDtMHbY6YTKJrEqJ
…to claude/project-thread-k88liz
ray build does not run tsc, so a '' | Market inference slipped through. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYf7vdDtMHbY6YTKJrEqJ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYf7vdDtMHbY6YTKJrEqJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third automated review on raycast/extensions#33098 found a real type error:
suffix && SUFFIX_MARKETS[suffix]infers"" | Market, sotscfails.ray builddoesn't run tsc, so neither local checks nor CI caught it.npm run typecheck(tsc --noEmit) and run it inmake test-raycast, so CI catches this from now onThe review's other two items (silent quote failures, catalog entry validation) point at code that was already fixed in #19.
Generated by Claude Code