Skip to content

Run format before format:check in init hydration test validation #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Palcimer wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Run format before format:check in init hydration test validation #952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/init/src/test/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ async function validateDevToolScripts(
if (format.code !== 0) return false;
}

for (const script of ["format:check", "lint"]) {
for (const script of ["format", "format:check", "lint"]) {

@coderabbitai coderabbitai Bot Jul 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Keep format out of the shared validation loop.

The Astro-specific block at Lines 146-156 already runs format, so this causes Astro projects to format twice. It also makes every non-Deno framework require a format script, although this change targets Astro and the previous shared validation only ran format:check and lint.

-  for (const script of ["format", "format:check", "lint"]) {
+  for (const script of ["format:check", "lint"]) {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
for (const script of ["format", "format:check", "lint"]) {
for (const script of ["format:check", "lint"]) {
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/init/src/test/create.ts` at line 158, Update the shared validation
loop to include only format:check and lint, removing format from the scripts
iterated there. Preserve the existing Astro-specific format execution so Astro
projects run format once, while other frameworks are not required to define a
format script.

const result = await $`${[packageManager, "run", script]}`
.cwd(dir)
.stdin("null")
Expand Down