WIP: unblock op/write.t format declarations - #1230
Merged
Merged
Conversation
Keep FormatNode instances during constant folding and emit their runtime registration in both the JVM and interpreter backends. This unblocks the initial format lookup fatal in op/write.t and adds focused regression coverage. Refs: #1116, #1229 Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <223364370+openai-codex[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP implementation for #1229, part of #1116.
op/write.twas terminating at its first test becauseFormatNodedeclarationswere discarded by constant folding. The fix preserves those nodes and registers
formats in both execution backends.
Plan
make.op/write.tformat semantics in follow-up commits.Validation
make: pass (after implementation fix).op/write.t: progressed from 0/636 blocked to 468/636 executed; remaining failures are later format semantics and are retained for this WIP investigation.