Repository navigation
ci: put semver_check = false in the [workspace] table - #150
Merged
Merged
Conversation
It was under [[package]] molecular-annotation, so release-plz still ran cargo-semver-checks for fibertools-rs and the published 0.13.0 baseline failed to build, blocking the 0.13.1 release PR.
This was referenced Sep 18, 2026
mrvollger
pushed a commit
that referenced
this pull request
Sep 18, 2026
## 🤖 New release * `fibertools-rs`: 0.13.0 -> 0.13.1 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.13.1](v0.13.0...v0.13.1) - 2026-09-18 ### Fixed - pin hts-sys 2.2.0 and turn off the release-plz semver check ([#148](#148)) - bump vergen-git2 to 9.1 so a fresh resolution builds again ([#146](#146)) - ft call-peaks --haps fills the H1/H2 columns ([#142](#142)) ### Other - put semver_check = false in the [workspace] table ([#150](#150)) - support patch releases from release/** branches ([#143](#143)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mrvollger
added a commit
that referenced
this pull request
Sep 18, 2026
release-plz 0.3.168 locates its open release PR with `opened_prs(pr_branch_prefix)`, which filters on the head branch name only and never on the base branch. Both branches used the default `release-plz-`, so the run after #150 merged found #132 (main's 0.14.0 release PR), force-pushed the 0.13.1 release onto its branch, and retitled it. #132 has been retargeted to `release/v0.13` and is now the correct 0.13.1 release PR. This sets `pr_branch_prefix = "release-v0.13-"` on this branch so future runs here create and update only `release-v0.13-*` PRs, and main's runs (default prefix) never see them. The old-prefix fallback in release-plz is `release-plz/`, which also does not match. **Merge after #132.** Merging this before #132 would make the next run here open a second 0.13.1 PR under the new prefix. --------- Co-authored-by: Mitchell R. Vollger <mvollger@gmail.com>
mrvollger
added a commit
that referenced
this pull request
Sep 18, 2026
Twin of #148 for main, rebased onto #147 so the two do not conflict on the release-plz.toml comment. Merging this brings in #147's commit too; #147 can then be closed as included. Same content as #148 plus the fix from #150: `semver_check = false` lives in the `[workspace]` table. **Do not merge until #132 (the 0.13.1 release PR on `release/v0.13`) is merged.** release-plz finds its open release PR by branch prefix only. A push to main with the semver check off would run release-plz-pr, find #132 by its `release-plz-` branch name, and force-push 0.14.0 content onto it. Today the only thing preventing that is main's run dying in the semver check, which this PR removes. After #132: merge this first on main, then #141 and #138. release-plz then opens a fresh 0.14.0 release PR. --------- Co-authored-by: Mitchell R. Vollger <mvollger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#148 placed
semver_check = falseafter the molecular-annotation[[package]]header, so it applied to that crate only. release-plz still ran cargo-semver-checks for fibertools-rs and failed on the published 0.13.0 baseline, exactly as #148 predicted for a check that is on (run 35359879404).Moves the key into
[workspace]. Merging this is a push, so release-plz runs again and should open the 0.13.1 release PR.