Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Final Hill marketing site to implement Issue #41’s marketing-page redesign: new positioning copy based on the five pillars, new home page structure, and supporting visuals, delivered via a new content-driven (YAML) home page layout in Nuxt.
Changes:
- Replaces the old markdown home page with a structured, section-based home page sourced from
content/0.index.ymland rendered by a newapp/pages/index.vue. - Adds new marketing visuals (hub-and-spoke, “what you see”, justification graph, evidence pack) and updates Cathedral/about copy to match the new positioning.
- Refactors layout/header/footer structure and updates icon/tailwind configuration to support the new page content.
Reviewed changes
Copilot reviewed 18 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| temp/marketing-page-redesign.md | Adds the detailed copy/pillars/page-structure draft used to drive the implementation. |
| public/assets/what-you-see.svg | Adds a 4-panel visualization mockup asset for the “What you see” section. |
| public/assets/justification-graph.svg | Adds a standalone justification graph marketing visual asset. |
| public/assets/hub-and-spoke.svg | Adds a hub-and-spoke architecture visual for the hero / “How it fits” section. |
| public/assets/evidence-pack.svg | Adds an evidence-pack export visual to make the “physical evidence” claim concrete. |
| package.json | Adds iconify JSON packs used by the new icon set. |
| package-lock.json | Locks the new iconify JSON dependencies. |
| nuxt.config.ts | Adds icon bundling config and adjusts Nuxt configuration for the new site structure. |
| content/solutions/cathedral.md | Rewrites Cathedral solution page to the new accountability/system-of-record positioning and adds visuals. |
| content/index.md | Removes the old home page markdown content. |
| content/about.md | Updates Vision/Mission copy to align with “machine-checkable requirements” and the accountability layer framing. |
| content/0.index.yml | Introduces the new structured home page content implementing the required section layout and copy. |
| content.config.ts | Adds a typed collection/schema for the new home-page YAML content. |
| app/pages/index.vue | Adds a new home page renderer that maps YAML sections/features into Nuxt UI sections/cards/CTA/FAQ. |
| app/layouts/default.vue | Refactors layout to use new header/footer components and UMain. |
| app/components/ImagePlaceholder.vue | Adds a placeholder card for sections without images. |
| app/components/HomeHero.vue | Removes the old hero/cards component used by the previous home page. |
| app/components/HeroBackground.vue | Adds a decorative hero background with a loading/appear transition. |
| app/components/AppHeader.vue | Extracts navigation/header into a reusable component with mobile menu support. |
| app/components/AppFooter.vue | Extracts footer into a reusable component with columns + social link. |
| app/assets/css/main.css | Updates Tailwind/Nuxt UI CSS setup (including @source and dark background variables). |
| app/app.vue | Adds global head/meta defaults (lang, theme-color, twitter card) and loading indicator. |
| app/app.config.ts | Adjusts Nuxt UI color configuration. |
Suppressed comments (2)
app/components/ImagePlaceholder.vue:15
- Follow-up to the stable-ID change: bind the pattern
idandrectfill to the per-instancepatternIdso each placeholder references its own<pattern>definition.
<pattern
id="pattern-placeholder"
x="0"
y="0"
width="10"
content/0.index.yml:269
- Same issue as above: “specification is just …” uses “specification” unqualified. To meet the acceptance criteria, either qualify it again or avoid the unqualified term.
justifiability, and more. Without machine-checkable specification,
specification is just better-documented ambiguity.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| index: defineCollection({ | ||
| source: '0.index.yml', | ||
| type: 'page', | ||
| schema: z.object({ |
| @import "tailwindcss"; | ||
| @import "@nuxt/ui"; | ||
|
|
||
| @source "../../content/**/*"; |
| @@ -0,0 +1,33 @@ | |||
| <template> | |||
Comment on lines
+209
to
+212
| Requirements are not prose in a document. They are machine-checkable records | ||
| that a compiler-like check engine can fail. This is the return channel the | ||
| RCT showed developers are missing. Without it, specification is just | ||
| better-documented ambiguity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41