Repository navigation
Motion polish for the new 0.1.5 features - #69
Merged
Merged
Conversation
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
… theme - Tab strip collapses height + fades in step with the sidebar slide when focus mode hides chrome (same 280ms, keyed on sidebar_gen) - Focus dimming fades lines toward/from muted over MOTION_IN_MS using the previous lit block; reduced motion snaps - Autoscroll (typing, find, typewriter recenter) glides scroll_y toward the target like the caret glide; wheel/trackpad stays 1:1 - Tab pills and the close button use hover_bg; new tabs fade in, closed tabs fade out via a brief ghost pill, and the unsaved dot fades via Presence - Text width eases the column cap over MOTION_IN_MS - Light/dark switches crossfade the Palette global via theme::lerp Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
devin/1791313892-motion-polish
branch
from
October 6, 2026 20:31
a899504 to
7fa2ac8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six abrupt state changes now animate with the app's existing motion vocabulary (
ease_out_quint,MOTION_IN_MS/MOTION_OUT_MS/MOTION_HOVER_MS,Presence,hover_bg). Everything honorscx.reduce_motion()by snapping to the end state.render_tabsnow returns an element whose height (34→0) and opacity collapse in the same 280mswith_animationkeyed onsidebar_genas the sidebar slide — previously the strip returnedNoneand vanished in one frame while the sidebar kept sliding.LiveEditorkeeps aDimFade { cur, prev, at };RunStyle::dim_runscomputes a per-linedim_amount(out ofprev→ out ofcur, eased) and lerps each run towardpal.muted, requesting frames untilt=1. Lines re-entering the block fade back.Layoutgained aglideflag; prepaint stepslayout.scrollhalfway toward the autoscroll target and repaints until <0.5px — the same pattern as the caret glide. The wheel path still writesscroll_ydirectly and clearsautoscroll, so trackpad scrolling stays 1:1.hover_bg; new pills fade in viawith_animation(("tab-in", id)); closing a tab pushes aClosingTabghost (capped at 8) that renders at its old index and fades out overMOTION_OUT_MSwhile siblings hold position until the fade ends; the unsaved dot fades viaPresence. (Said ghost approach means closed-tab fade-out IS mounted — no instant removal needed.)set_max_colseedscol_anim (from, to, at)(from the current eased value when retargeting mid-flight); prepaint easesmax_coland requests frames while running.apply_themeinspaces_ui.rscaptures the oldPalette, applies the target viatheme::apply, then sets the old global back and spawns a task lerpingcx.set_global(theme::lerp(&from,&to,t))+cx.notify()each ~16ms until done — no render-site edits needed.theme::lerpis a channel-wiseu32lerp (3-channel forrgb, 4-channel forrgbafields) with a unit test.GUI verification (macOS, release build)
Verified live in the app with 60fps capture; every transition shows multi-frame intermediate states (not one-frame snaps).
Focus mode — sidebar slide + tab-strip collapse together; dim fades on caret moves; typewriter recenter glides:
Tabs — pill fades in on open; closed pill leaves a fading ghost while siblings hold position:
Theme crossfade — palette lerps over ~160ms (mid-fade is visibly mixed):
Also verified live: find-next scroll glides with an asymptotic tail while wheel scrolling steps discretely 1:1; Settings → Text width glides the column; the unsaved dot fades in with the dirty state.
Notes for reviewers
RunStylenow takesfade_from/fade_talongsidefocus;dimmed()was replaced by the easeddim_amount().open_path); Cmd+click opens a second tab — pre-existing behavior, unrelated to this PR.Link to Devin session: https://app.devin.ai/sessions/308b6c12ce7b420588973691e7035d63
Open in Devin Desktop: https://app.devin.ai/desktop/session/308b6c12ce7b420588973691e7035d63?variant=devin
Requested by: @horizzon3507