Skip to content

Swap attach_blob and attach_tree parameter order - #67

Merged
keithw merged 1 commit into
mainfrom
fixshell-parameter-swap
Sep 15, 2026
Merged

keithw merged 1 commit into
mainfrom
fixshell-parameter-swap

Conversation

@Haibib

@Haibib Haibib commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

PR Description

  • Swapped the order of attach_tree and attach_blob parameters in fixshell from (index, handle) to (handle, index).
  • This is useful to avoid argument reordering in the fix utility library's operation resolution chain because externref handles are produced before the table/memory index.

@Haibib
Haibib requested a review from keithw September 14, 2026 23:43
@Haibib
Haibib force-pushed the fixshell-parameter-swap branch from f283075 to 6df69b2 Compare September 14, 2026 23:45
@Haibib
Haibib force-pushed the fixshell-parameter-swap branch from 6df69b2 to 6dbb16d Compare September 14, 2026 23:50
@keithw

keithw commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Can you briefly say why in the PR message so we know why we did this?

@Haibib

Haibib commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Can you briefly say why in the PR message so we know why we did this?

Yes, I added a brief explanation.

@keithw

keithw commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Great!

@keithw
keithw merged commit e279e3e into main Sep 15, 2026
6 checks passed
@keithw
keithw deleted the fixshell-parameter-swap branch September 15, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants