Repository navigation
build: fizzy ships its android folder to apps that fetch it - #1212
Merged
Merged
Conversation
Signed-off-by: fizzy pop-os-claude-2 <slot+pop-os-claude-2@fizzy.invalid>
Contributor
Where this PR standsStage: Author's turn What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Rules that apply: touches build scripts. Reviews at the current commit (
Updated 2026-11-11 18:56 UTC by the PM. This comment is edited in place. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In plain words
An app built on fizzy that downloads fizzy as a package could not build an Android version: the
download left out the folder of Android pieces the build needs. Fizzy now includes that folder in
what it ships, so such an app builds its Android package the same way fizzy does.
What changes
"libs", "web", + "android", },What you will notice
Nothing visible: internal. An app that fetches fizzy by URL (Heronin is the first) can now run
zig build apkand get an Android package, where before it stopped with a missing-file error.How we know it works
Without the change, Heronin pinned to fizzy fails its Android build with "unable to load
sdl_main.zig: FileNotFound". Putting fizzy's Android folder into the fetched package by hand made
the same build write a 16.7 MB debug
heronin.apk(packagedev.fizzy.heronin), with fizzypinned at both
38dc20d7and7bdfdad6; nothing else was missing.zig buildandzig build testpass here.How this serves fizzy
It moves fizzy toward running on every platform:
an app built on fizzy reaches Android phones without copying fizzy's Android files itself.
Part of fizzyedit/work#1187
For agents: technical summary
Goal
A URL-fetched consumer of fizzy builds its APK. Zig filters a fetched package by
.paths, andandroid/was not listed.What changed and why
build.zig.zon:"android"added to.pathsafter"web". The consumer needs it becausesrc/Entry.zig:891importsandroid_sdl_main(android/sdl_main.zig) andbuild/android.zig:87-90runs
android/package.shwithandroid/AndroidManifest.xmlandandroid/src/FizzyActivity.java.Path dependencies (the console) are not filtered by
.paths, which is why they never hit this.How it was verified
scripts/zb build: passes.scripts/zb build test --summary all:225/225 steps succeeded.android/into the fetchedzig-pkg/fizzy-...by hand makes Heronin'szig build apkwrite a 16.7 MB debug APK,aapt dump badgingshowsdev.fizzy.heronin. Not rerun here (no Android SDK in this slot).Not done / follow-ups
Part of fizzyedit/work#1187