Skip to content

build: fizzy ships its android folder to apps that fetch it - #1212

Merged
fizzy-publish[bot] merged 1 commit into
mainfrom
android/apk-package-paths
Nov 11, 2026
Merged

fizzy-publish[bot] merged 1 commit into
mainfrom
android/apk-package-paths

Conversation

@fizzy-publish

@fizzy-publish fizzy-publish Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

In plain words

An app built on fizzy that downloads fizzy as a package could not build an Android version: the
download left out the folder of Android pieces the build needs. Fizzy now includes that folder in
what it ships, so such an app builds its Android package the same way fizzy does.

What changes

  • The list of folders fizzy's package ships to apps that fetch it now includes the Android folder.
         "libs",
         "web",
+        "android",
     },

What you will notice

Nothing visible: internal. An app that fetches fizzy by URL (Heronin is the first) can now run
zig build apk and get an Android package, where before it stopped with a missing-file error.

How we know it works

Without the change, Heronin pinned to fizzy fails its Android build with "unable to load
sdl_main.zig: FileNotFound". Putting fizzy's Android folder into the fetched package by hand made
the same build write a 16.7 MB debug heronin.apk (package dev.fizzy.heronin), with fizzy
pinned at both 38dc20d7 and 7bdfdad6; nothing else was missing. zig build and
zig build test pass here.

How this serves fizzy

It moves fizzy toward running on every platform:
an app built on fizzy reaches Android phones without copying fizzy's Android files itself.

Part of fizzyedit/work#1187

For agents: technical summary

Goal

A URL-fetched consumer of fizzy builds its APK. Zig filters a fetched package by .paths, and
android/ was not listed.

What changed and why

build.zig.zon: "android" added to .paths after "web". The consumer needs it because
src/Entry.zig:891 imports android_sdl_main (android/sdl_main.zig) and build/android.zig:87-90
runs android/package.sh with android/AndroidManifest.xml and android/src/FizzyActivity.java.
Path dependencies (the console) are not filtered by .paths, which is why they never hit this.

How it was verified

  • scripts/zb build: passes.
  • scripts/zb build test --summary all: 225/225 steps succeeded.
  • APK evidence from the spec (Architect t355, pop-os): extracting android/ into the fetched
    zig-pkg/fizzy-... by hand makes Heronin's zig build apk write a 16.7 MB debug APK,
    aapt dump badging shows dev.fizzy.heronin. Not rerun here (no Android SDK in this slot).

Not done / follow-ups

  • Heronin bumps its fizzy pin after this merges (its K10a).

Part of fizzyedit/work#1187

Signed-off-by: fizzy pop-os-claude-2 <slot+pop-os-claude-2@fizzy.invalid>
@fizzy-publish fizzy-publish Bot added kind:claude agent kind that wrote the PR (new workflow) area:android write lock: files of this area gate:yes risky path: PM or maintainer looks labels Nov 11, 2026
@fizzy-pm fizzy-pm Bot added pm:review one assigned reviewer reviews reviewer:linux-codex the PM assigned linux/codex to review this PR labels Nov 11, 2026
@fizzy-publish
fizzy-publish Bot enabled auto-merge November 11, 2026 18:40
@fizzy-pm

fizzy-pm Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Where this PR stands

Stage: Author's turn
Next: Author should add the gates you ran, and their result, to the body

What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):

  • The body names its basis (Part of fizzyedit/work#N or a plan step)
  • Within the size limit: 1 of 800 lines outside tests and docs
  • The body shows which gates the author ran
  • No open findings at this commit
  • Every earlier finding was answered in a FIXES comment
  • Clean reviews at this commit from 2 different kinds: slot/codex (has 1)
  • Marked ready, which starts the full CI (the PM does this the moment the items above are met)
  • The full CI passes at this commit (CI is green)
  • The PM's final okay (pm-approval)

Rules that apply: touches build scripts.

Reviews at the current commit (d483089):

Reviewer Verdict Findings
slot/codex clean none

Updated 2026-11-11 18:56 UTC by the PM. This comment is edited in place.

@fizzy-pm fizzy-pm Bot removed pm:review one assigned reviewer reviews reviewer:linux-codex the PM assigned linux/codex to review this PR labels Nov 11, 2026
@fizzy-publish
fizzy-publish Bot added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit d9d816d Nov 11, 2026
41 checks passed
@fizzy-publish
fizzy-publish Bot deleted the android/apk-package-paths branch November 11, 2026 19:17

This branch was successfully deployed

1 active deployment
bridge — d4830898 Deployed Nov 11, 2026 by fizzy-publish[bot] via bridge #4863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:android write lock: files of this area gate:yes risky path: PM or maintainer looks kind:claude agent kind that wrote the PR (new workflow)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants