Repository navigation
slot: reviews and rework work for every target repo - #1215
Open
fizzy-publish[bot] wants to merge 1 commit into
Open
fizzy-publish[bot] wants to merge 1 commit into
fizzy-publish[bot] wants to merge 1 commit into
Conversation
Signed-off-by: fizzy pop-os-claude-1 <slot+pop-os-claude-1@fizzy.invalid>
Contributor
Where this PR standsStage: PM's turn What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Reviews at the current commit (
Updated 2026-11-11 20:19 UTC by the PM. This comment is edited in place. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In plain words
Fizzy's automated agents write and review changes for several repositories, not only fizzy itself. For the other repositories, the request that should start a review was sent under a name nothing listens for, so those changes were never reviewed. Review notes for a change in another repository could also land on the wrong discussion thread. This change makes reviews and follow-up fixes work for every repository the agents serve.
What changes
What you will notice
Nothing visible: internal. Changes the agents make to the other fizzyedit repositories now get reviewed and reworked the same way fizzy's own changes do.
How we know it works
New tests run the publisher against a fake GitHub: they check that the right review request is sent exactly once over two runs, that each repository's change gets its own thread (created once when missing), that fixes in another repository trigger a second-round review while fizzy's do not, and that the invisible marker is removed from a copied review file. They fail without this change.
How this serves fizzy
It makes the agent pipeline serve the whole set of repositories fizzy is built on, part of fizzy as a platform.
Part of fizzyedit/work#1193
For agents: technical summary
Goal
dispatch_reviewsentrepository_dispatchreview, which no workflow listens for; review.yml listens forprwith{pr, sha, repo, round}. Review threads were keyedPR #N:regardless of target repo, so a heronin PR #9 collided with fizzy PR #9.What changed and why
common.thread_title(repo, number):PR #N:for fizzyedit/fizzy,PR <name>#N:otherwise.publish.pyreview branch: search"<title>" in:title, keep titles starting with it; none →gh issue createapr-threadissue (title + PR title[:90], body linking PR and work issue) and use it; more than one → refuse as before.dispatch_review(pr, round): eventpr, payload{pr, sha (head of repos/<target>/pulls/<pr>), author_kind, repo, round}; write and resume send round 1. Rework branch: after the push, whendestination['gate'], dispatches with the rework round under its own receipt marker (slot-rework-review); the early return became a guard so a rerun can resume the dispatch. fizzy (gate False) sends nothing.slot_run.py: agent outputs copied into out/agent with a leading UTF-8 BOM dropped.read_agentstill reads utf-8-sig.How it was verified
New tests:
test_heronin_write_dispatches_pr_once,test_heronin_review_comments_on_its_own_thread,test_missing_heronin_thread_is_created_once,test_dvui_rework_dispatches_review_round_once,test_fizzy_rework_dispatches_nothing(test_publish),test_bom_led_review_json_is_copied_without_bom(test_slot_run). Updated:test_dvui_write_dispatches_review_once,test_dvui_existing_pr_resumes_review_dispatch(to theprpayload);test_dvui_clean_review_never_auto_mergesandtest_dvui_changes_dispatch_carries_reponow seed aPR dvui#9:thread. The agent session could not execute Python (sandbox approval), so the gatepython3 -m unittest discover -s scripts/slot/tests -t scriptsis left to the slot's own gate run.Not done / follow-ups
gh(scripts/slot/fakes/gh.py) has noissue create; the thread-creation test answers it in-process by patchingslot.publish.gh. Teaching the fakeissue createwould be cleaner but was out of the editable paths.Part of fizzyedit/work#1193