Repository navigation
heronin: photo facts, thumbnails and tags come from Drive - #35
Merged
Merged
Conversation
Signed-off-by: fizzy pop-os-codex-2 <slot+pop-os-codex-2@fizzy.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heronin: photo facts, thumbnails and tags come from Drive
In plain words
Photos stored in Drive now bring their dates, camera details, dimensions, tags and favorites into Heronin. Thumbnail requests and tag edits can wait for Drive to answer. Imports distinguish different photos that happen to have the same file size.
Part of fizzyedit/work#1185
What changes
What you will notice
Drive photo details, tags and favorites populate the library. Tagging can run with Drive mounted. Drawing the returned thumbnail images remains a separate task.
How we know it works
In-process fakes check metadata, deferred thumbnails, property writes, listing refreshes, same-size import collisions and compatibility with older Drive versions. All six requested gates pass.
How this serves fizzy
The platform lets Heronin use Drive's photo capabilities through named commands without linking Drive into the app.
For agents: technical summary
Goal
Connect the store to Drive D3/D4 commands while preserving older-host behavior.
What changed and why
Meta has three function pointers and a context. Each deferred operation uses one Pending, with results copied into the existing answer queue. Host event parsing uses std.zon.parse.fromSlice and defaults missing props to an empty object. Successful imports expose the content MD5.
Source budget: 206 added non-test lines and 420 added-plus-deleted lines including tests, from
git diff --numstat HEAD. No new source files were added (wc -lcontribution: 0). The PR page and report are delivery artifacts.How it was verified
Passed:
zig fmt --check build.zig tools tests/check_public model app server,zig build,zig build server,zig build test,zig build web, andzig build check-public.git diff --checkalso passes. New tests require Meta and exercise behavior unavailable on main.Not done / follow-ups
No live Drive service was exercised. Rendering encoded thumbnails and linking Drive remain separate work. No build files, views, server, FakeStore, drive_props, or store interface changed.
Part of fizzyedit/work#1185