Repository navigation
heronin: place names stop growing and rescanning - #36
Merged
Merged
Conversation
Signed-off-by: fizzy pop-os-codex-1 <slot+pop-os-codex-1@fizzy.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heronin: place names stop growing and rescanning
Part of fizzyedit/work#1186
In plain words
Looking up names for photo locations now uses less memory as your library grows. Once every location has been checked, fizzy avoids searching the same unchanged library again.
What changes
What you will notice
Nearby names still appear with “near” before saving. Saved names and later renames appear consistently in photo labels.
How we know it works
An in-process test answers 200 distinct photo locations and checks memory use and completed-search invalidation. The fixed arena measures 50,778 bytes; temporarily restoring the old per-answer reallocation strategy measures 696,288 bytes and fails the 128 KiB limit. The rename test checks “near Sea Mount”, “Sea Mount”, then “Point” through the shared photo-label function inside frames.
All six requested gates pass, including all 67 test build steps. No socket exceptions were needed.
How this serves fizzy
Platform: efficient location lookup keeps larger photo libraries practical across devices.
For agents: technical summary
Goal
Bound answer-storage growth and avoid repeated scans of unchanged inputs while preserving place-label behavior.
What changed and why
Answers use an ArrayList allocated from the existing arena. A completed scan records the photo pointer, photo count, saved count and answer count. The logic label function accepts an allocator, and the three views call the shared photoPlace composition. Invalid points return an explanatory 400 body.
Budget: 23 added non-test source lines (cap 55); 122 added plus deleted source/test lines (cap 170). Counts use git diff --numstat HEAD; no new source files. Delivery artifacts are excluded under R5.
How it was verified
Not done / follow-ups
Out-of-scope work remains untouched. No commit, staging, publishing or GitHub actions were performed.
Part of fizzyedit/work#1186