Repository navigation
heronin: pin fizzy with the Android launch fix - #40
Merged
Merged
Conversation
Signed-off-by: fizzy pop-os-codex-3 <slot+pop-os-codex-3@fizzy.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heronin: pin fizzy with the Android launch fix
In plain words
Heronin now uses the fizzy revision containing the Android launch fix. This brings the upstream fix into Heronin; launching it on a phone still needs to be checked after merge.
What changes
612f90b8aa1282f3d1fe1b79b1675a8a677af193and its package hash.What you will notice
The update is intended to fix Android launch. The APK build and phone launch could not be verified in this job.
How we know it works
The pin check prints
1, and formatting passes. All five build gates and the APK build stop at dependency fetching withserver connection failed: Unexpected; a separate download attempt reports that github.com cannot be resolved. No tests reached execution. The upstream socket-folder implementation could not be inspected because the dependency was not fetched.How this serves fizzy
Platform support: bringing the Android launch fix into Heronin supports people using fizzy on Android.
Part of fizzyedit/work#1200
For agents: technical summary
Goal
Pin Heronin to fizzy's Android launch fix without changing application code.
What changed and why
Only the fizzy dependency line in
build.zig.zonchanges. SHA:612f90b8aa1282f3d1fe1b79b1675a8a677af193. Hash:fizzy-0.2.0-c46aVj9UyQDD3hiUClf4LvLikHxmdenMg-ghakvXMjgO.Budget:
git diff --numstat HEADreports 1 added, 1 deleted line inbuild.zig.zon; 0 new non-test implementation lines. The requested PR page and report are delivery artifacts outside the implementation budget.zig fetch --save=fizzyfailed before updating the manifest, so the specified URL and hash were applied directly, preserving the rest of the file.How it was verified
grep -c 612f90b8aa1282f3d1fe1b79b1675a8a677af193 build.zig.zon:1.zig fmt --check build.zig tools tests/check_public model app server: exit 0.zig build,zig build server,zig build test,zig build web,zig build check-public: each exit 1 at dependency fetching withserver connection failed: Unexpected.PATH=/opt/android-jdk/bin:$PATH JAVA_HOME=/opt/android-jdk zig build apk -Dtarget=aarch64-linux-android -Dandroid-sdk=/opt/android-sdk: exit 1 at the same dependency-fetch error.APK evidence command:
Output (exit 1):
Output (exit 2):
Not done / follow-ups
Rerun the build gates and APK evidence when the dependency is available. Verify the fetched
app/control/Server.zigusesopenDirwith.follow_symlinks = falseand sets socket-folder mode through the fd. These remain unverified here. The Architect's reported green trial was not independently reproduced. Phone launch is Ops' A7 smoke after merge; release key, install script, and console pin remain outside this change.Part of fizzyedit/work#1200