Repository navigation
heronin: a Map tab with a dot for each place - #45
Merged
Merged
Conversation
Signed-off-by: fizzy pop-os-codex-4 <slot+pop-os-codex-4@fizzy.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heronin: a Map tab with a dot for each place
In plain words
A Map tab shows where your photos were taken, with one dot for each place. Tap a dot to see the species photographed there.
What changes
What you will notice
Map appears between Species and Add. It frames your places automatically; you can scroll, zoom and tap a place to explore its species.
How we know it works
The test
Map frames every place, reserves attribution, zooms around center and opens specieschecks the phone-sized layout, every place dot, zoom centering and navigation. All six requested gates pass. Tile display on a phone or browser is UNVERIFIED and needs M1a deployed; Ops checks it after merge.How this serves fizzy
The platform vision advances through a map that connects photos and species to their places.
Part of fizzyedit/work#1219
For agents: technical summary
Goal
Implement M1b-2 using the existing Mercator geometry and tile client.
What changed and why
A view-local zoom, framing flag and scroll state drive tiles and place dots. The plugin steps signed-in tile requests and refreshes loading and newly queued requests.
Budget: 72 added non-test lines; 121 added + deleted lines including tests. Counts use
git diff --numstat HEADplus 62 lines in the new map view; test files are excluded only from the first count.How it was verified
Passed:
zig fmt --check build.zig tools tests/check_public model app server,zig build,zig build server,zig build test,zig build web,zig build check-public.Not done / follow-ups
UNVERIFIED: real tile rendering on a phone or browser requires deployed M1a. No screenshots were taken. Ops owns that check after merge.
Part of fizzyedit/work#1219