Repository navigation
fix(rum): keep remote settings across app upgrades - #32
Merged
Merged
Conversation
The stored remote configuration was keyed on the application version as well as the intake, application id and env, so every app upgrade discarded it. The first session after an upgrade was then drawn on the init values and reported no rcVersion, even though the previous release's settings are the better answer until the new fetch lands. Drop the application version from the identity. An installed app runs one version at a time and the console offers no per-version targeting. The version is still sent as app_version on each request. Files written by earlier builds carry the old four-part identity and no longer match, so the first launch after this SDK upgrade discards the cache once and then rewrites it under the new identity.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The stored remote configuration was matched on
[proxy ?? site, applicationId, env, version], withversionbeing the application's own version. Every app upgrade therefore discarded it. The first session after an upgrade was drawn on the init values and reported norcVersion.Change
app_versionis still sent on each request.Verification
vitest run --coverage: 40 files, 1033 tests passed.yarn typecheckis clean.prettier --check src README.mdis clean.eslinton the changed files is clean.app_versionandapplied_versionare still sent;config.versionback in the identity, the remote configuration spec fails.