Repository navigation
Doc Review 2026-10-09 — dashboard time variables & display time zone, RUM Explorer analytics, MCP/Go-SDK OAuth, CLI --timezone - #1034
Merged
Conversation
…ay time zone, RUM Explorer analytics, MCP/Go-SDK OAuth, CLI --timezone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc Review — 2026-10-09
Mode: diff (since
2026-10-08T08:07:17Z, the previous successful run)Findings: 28 total — 5 high, 15 medium, 8 low
Applied: 25 (25 doc findings + 1 derivative changelog) · Deferred to api-review: 1 · Skipped: 1 (see below) · Cross-repo follow-up: 1
Window scanned across 24 repos/submodules. Zero-commit repos in this window (verified
base == headagainst the remote ref, with a positive control at an earlier timestamp):fc-oncall,fc-datasource,terraform-provider-flashduty,flashduty-app,fc-statuspage,flashduty-runner,monit-edge,fc-pgy(commits present, none in mapped paths),ai-assistant-web,meow-ui.Changes
developer/cli.mdxautomation create/updatenow both take--timezone; added it to thecreateparameter table and theupdatemodifiable-field list; documented the omit → member/account/Asia/Shanghaichain, the explicit-empty → UTC case, and thatupdaterecomputesschedule_next_fire_at_msdeveloper/cli.mdxalert list --alert-ids/--alert-keys/--asc/--by-updated-atandalert-event list --ascdeveloper/cli.mdxincident comment --comment-type-idin the 评论类型 sectiondeveloper/cli.mdxincident feed <id>with--asc/--typesdeveloper/cli.mdxINSTALLED_NAMErow and the renamed-binary behaviourdeveloper/cli.mdxFLASHDUTY_BASE_URL,FLASHDUTY_NO_UPDATE_CHECK, …)developer/go-sdk.mdxNewClientWithAccessToken; corrected the Tip that claimedapp_keyis the only credentialopenapi/go-sdk.mdxdeveloper/mcp-server.mdxdeveloper/mcp-server.mdxoauth:prefix,401+WWW-Authenticate, the three/.well-known/oauth-protected-resourceendpointsdeveloper/mcp-server.mdxbase_urlremote query parameter (APP-key only)monitors/dashboards/dashboards.mdx$__interval/$__rate_interval/$__range/$__auto, rendered values, datasource × query-mode availability matrixmonitors/dashboards/dashboards.mdxmonitors/dashboards/dashboards.mdx__prefix to the variable-naming rulemonitors/dashboards/dashboards.mdxmonitors/explore/explore.mdxrum/explorer/analytics.mdx(+docs.jsonnav in both languages, + cards inrum/explorer/overview.mdx)rum/quickstart/app-management.mdxrum/quickstart/app-management.mdxremoteConfigurationEnabledto the miniprogram field table and sample codeai-sre/im.mdxai-sre/automations.mdxai-sre/automations.mdxai-sre/memory.mdxai-sre/mcp.mdxchangelog/changelog.mdx<Update>block for this window's shipped featuresReview checklist
$__rate_intervalarithmetic inmonitors/dashboards/dashboards.mdx)rum/explorer/analytics.mdxpage is entirely new and the largest addition here; please read the chart/drill-down semantics against a real Explorer sessiondeveloper/mcp-server.mdxOAuth section describes the flow you want customers to follow (the MCP OAuth story is told across the deployment tabs and a new subsection)Cross-repo follow-ups (flashduty-website)
content/changelog/2026-10-05-341202.mdx; nothing covers the features shipped on 2026-10-08/09 that this round documents (dashboard built-in time variables + display time zone, RUM Explorer analytics, MCP/Go-SDK OAuth, CLI--timezone). Suggested action: publish a dated.mdx+.zh.mdxpair for the same window. Not edited by this PR (different repository).Not a finding, checked by hand:
lib/integrations/catalog.tsinflashduty-websitechanged in this window, but it is a pure reorder — 346 entries before and after with identical id sets — so no catalog entry was added or removed and the 「267 alert / 41 change integrations」 claims still hold (re-counted againstfc-datasource:structs/plugin.goonorigin/main).Mapping warnings
derivative_surfaces.comparison_page.pathsin.claude/skills/doc-review/mapping.yamlpoints atzh|en/on-call/quickstart/comparison.mdx, which does not exist. The real comparison pages arezh|en/on-call/comparison/vs-pagerduty.mdxandvs-opsgenie.mdx. This is the 6th consecutive round this entry has been silently skipped by the skill; the comparison check was therefore run by hand against the real directory this round, and both pages' Flashduty-side 「267 集成源」 cell still matches the registry count. The fix belongs in the skill'smapping.yaml, not in the docs repo — flagging it here again because it cannot be fixed from this PR.Skipped
investigation_targets(排障落点). The capability is real:monit-webapimodel/alert_rule.go:51carriesInvestigationTargets []types.InvestigationTarget, with a save-time Edge version gate inlogic/alert_rule_investigation_edge_gate.go. It is not written into the docs, for two reasons: (1) the feature dates from commited524bdon 2026-09-02, i.e. it is not a change in this window — the only in-window signal was the rewrite of the agent-facing reference cardfc-safari:logic/runtime/bootstrap/skills/flashduty/reference/monit-rule.md; and (2) it has no console surface —git grep investigationoverfc-foundation-app/src/Packages/monit/pagesonorigin/mainreturns nothing, so documenting it insidemonitors/quickstart/quickstart.mdx(a walkthrough of the five form blocks) would describe a control that does not exist. It is reachable only through the rule API/CLI body. Decision needed from the docs owner: whether the API/CLI-only surface should be documented at all, and if so where. Not applied rather than guessed at.