[FBumann]

Prompt: And what of this is a bug on main that should land there independently?

Note

The following content was generated by AI.

diagnostics().omissions now counts every row a constraint did not build. Before, a constraint that lost rows to a restriction and also rows with no term reported only the second count.

Cause, test, gates

Cause. _build_constraint records the rows a restriction removed with .get(name, 0) +. _drop_termless_rows then wrote its own count with =, which replaced the first one.

Test, written first as a strict xfail and watched to fail on af1dac7: test_rows_a_restriction_removed_and_rows_with_no_terms_are_counted_together. p is absent at a, so the restriction removes that row. k has no value at b, so that row has no term. On main, rows_not_built is 1, where 2 is correct.

Fix. += in _drop_termless_rows. The built model does not change; only the report does.

Gates, in a uv venv on polars 2.0.0 (no pixi in this container): ruff check . and ruff format --check . at 0.16.9, pyrefly check on src/ at 1.3.1 (0 errors), pytest -n auto tests: 5449 passed, 657 skipped, 4 xfailed, and 2 failed. The 2 failures are the [xpress] cases, which fail on main too because the xpress package is not installed here. docs-test was not run.

Not done. #2022 rewrites this function. When it merges main, the resolution keeps its version with this +=; #2027 already has it there.

🤖 Generated with Claude Code

https://claude.ai/code/session_013DSGmeGQfUxE4gyNQy94qG

---

Generated by Claude Code

[read-the-docs-community]

Documentation build overview

📚 specsolve | 🛠️ Build #35118306 | 📁 Comparing 32ca3d6 against latest (af1dac7)

  🔍 Preview build  

1 file changed

± about/changelog/index.html

[codspeed]

Merging this PR will degrade performance by 12.86%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 7 regressed benchmarks
✅ 97 untouched benchmarks
⏩ 307 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
❌	test_emit[network-s-specsolve-in-memory-lp]	28.2 MB	34.5 MB	-18.2%
❌	test_emit[network-s-specsolve-lp]	28.2 MB	34.5 MB	-18.2%
❌	test_emit[network-s-specsolve-highs]	19.5 MB	21.8 MB	-10.7%
❌	test_emit[network-s-specsolve-in-memory-highs]	19.5 MB	21.8 MB	-10.69%
❌	test_window[network-s-specsolve-highs-cold]	19.6 MB	21.9 MB	-10.65%
❌	test_window[network-s-specsolve-highs-coefficient]	19.6 MB	21.9 MB	-10.54%
❌	test_window[network-s-specsolve-highs-shape]	19.5 MB	21.8 MB	-10.54%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing fix/omitted-rows-counted (32ca3d6) with main (b646d61)²}

Footnotes

1. 307 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (454e6de) during the generation of this report, so b646d61 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩