Repository navigation
Fix/critical pin - #7187
Merged
Merged
Fix/critical pin#7187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ix(notes): amber warning icon in red themes
Follow-up to #7146. In the red colour themes, the brand colour is already red, so the red warning note icon blended in with everything else on the page.
Changes
• Warning notes keep the same info icon, but in the Carnation and Cerise colour themes they switch from red to amber (darker amber in light mode for contrast).
• All other themes are unchanged.
• CONTRIBUTING mentions the amber exception.
To check
• Carnation and Cerise themes, light and dark mode
• Default theme, to confirm nothing changed