Repository navigation
Conversation
The warning dialog used to open for the first link in any list item with a critical note. On the Beginners Guide, AudiobookBay's warning opened on Mobilism Audiobooks and not on AudiobookBay, and mirrors and peers such as WinRAR [2], MyInsta, HushGram, Instafel and Betterfox skipped their warning. Guarded links are now tagged with data-critical-note at build time: every primary peer and numbered mirror before the description, or, on the Beginners Guide, the link right before the warning. Layout.vue opens the dialog only for tagged links.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning dialog used to open for the first link in any list item with a critical note. On the Beginners Guide, AudiobookBay's warning opened on Mobilism Audiobooks and not on AudiobookBay, and mirrors and peers such as WinRAR [2], MyInsta, HushGram, Instafel and Betterfox skipped their warning.
Guarded links are now tagged with data-critical-note at build time: every primary peer and numbered mirror before the description, or, on the Beginners Guide, the link right before the warning. Layout.vue opens the dialog only for tagged links.