Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…heck Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…er factory tests, fix functional test setup Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the "vibes 1" milestone.
complexitycheck that runs complexipy as a library on the source files (tests excluded). It passes when no function is abovemax_complexity(default 15) and lists the offending functions otherwise. A file complexipy cannot parse fails the check without hiding the other files.max_complexitymust be a positive integer. complexipy moved to the runtime dependencies.grader/py.typedmarker (and list it in the package data) so library users get the type information. The globalignore_missing_importsis gone frommypy.iniand thejustfile; onlycove_sdk.*is ignored, until py-cove ships its ownpy.typed.os.pathusage replaced withpathlibingrader/,desktop/and the tests. Public method signatures still takestr; path constants are nowPath.assert,pytest.raises,tmp_pathand alog_outputfixture (intests/conftest.py) in place ofassertLogs.unittest.mockis kept.justfile, coverage and CLAUDE.md now use pytest.tag-releasejob incicd.yml, so there is no code change here and the issue can be closed.Closes #78, #75, #65, #101, #56
Behaviour notes
find_all_files_under_directorynow usesPath.rglobinstead ofos.walk.SpecCheckno longer crashes on a symlinked source file that resolves outside the project root (found in review)./now yields its last path segment as the temp filename instead ofdownloaded_file.Test plan
just lint(ruff, mypy, complexipy)just unit_tests- 268 passed;just coverage- 93%just functional_tests- these clone the remote and check out the current branch, so they only work once the branch is pushed; they are running now and CI will run them too🤖 Generated with Claude Code