Skip to content

fix: display partial cancellations on invoice pdf file - #1053

Merged
smarcet merged 3 commits into
masterfrom
fix/order-invoice-partial-cancellation
Aug 27, 2026
Merged

fix: display partial cancellations on invoice pdf file#1053
smarcet merged 3 commits into
masterfrom
fix/order-invoice-partial-cancellation

Conversation

@tomrndom

@tomrndom tomrndom commented Aug 26, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bbgchzp

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Updates
    • Updated the underlying UI foundation to the latest stable release.
    • Includes the newest available improvements and fixes for a more reliable and polished interface.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5d7776b8-2a57-4ad7-9ec8-756f9a7182be

📥 Commits

Reviewing files that changed from the base of the PR and between a0bda11 and d79f2ae.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The pull request updates the openstack-uicore-foundation dependency from 5.0.53-beta.2 to 5.0.54 in package.json.

Changes

Foundation dependency update

Layer / File(s) Summary
Update foundation dependency
package.json
The dependency version changes from 5.0.53-beta.2 to 5.0.54.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d79f2

No actionable merge-blocking risk remains; the PR is ready for normal checks and review.

Suggested reviewers: santipalenque, smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the intended change: invoice PDF files display partial cancellations. This matches the stated PR objective and the dependency update that implements the fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/order-invoice-partial-cancellation

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

Parsing error: Missing semicolon. (2:8)


Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
smarcet merged commit d5ac0ab into master Aug 27, 2026
9 checks passed
smarcet pushed a commit that referenced this pull request Aug 28, 2026
* fix: display partial cancellations on invoice pdf file

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

* fix: bump uicore beta version

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

* fix: update uicore to 5.0.54

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

---------

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants