fix(mcp): initialize environment before handling requests - #410
Merged
Merged
Conversation
Issue: Homebrew-installed architect-mcp aborted during tools/call because control-socket discovery accessed env before the MCP entrypoint initialized it. Solution: Initialize the process environment from std.process.Init before entering the stdio request loop and register the shared environment module for the MCP target. Add an end-to-end regression that invokes the real entrypoint with isolated runtime state and verifies the structured app-not-running response.
forketyfork
marked this pull request as ready for review
September 13, 2026 07:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Homebrew-installed
architect-mcpaccepted initialization and tool-list requests but aborted ontools/callbecause control-socket discovery accessed the process environment before it was initialized. MCP clients reported the resulting process exit asTransport closed.Solution
Initialize the process environment from
std.process.Initbefore the MCP stdio loop starts, and register the shared environment module for the MCP target. Add an end-to-end regression that invokes the real entrypoint with isolated runtime state and verifies the structuredapp_not_runningresponse.Context
The helper forwards
spawn_sessionrequests to a running Architect instance through the local control socket. No issue link was provided.