Repository navigation
feat(networkpolicies): simplify Stack ingress isolation - #553
Merged
Merged
Conversation
NumaryBot
added
risk: medium
NumaryBot
previously approved these changes
Oct 14, 2026
NumaryBot
left a comment
NumaryBot
left a comment
Contributor
There was a problem hiding this comment.
The required automated review completed with no remaining findings.
NumaryBot
added
review-approved
NumaryBot
approved these changes
Oct 14, 2026
NumaryBot
left a comment
NumaryBot
left a comment
Contributor
There was a problem hiding this comment.
The required automated review completed with no remaining findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace per-module Stack ingress exceptions with two policies: allow all pod traffic within the Stack namespace, and allow cross-namespace/external traffic to the Gateway on TCP 8080. Direct access to other Stack pods remains blocked; these policies do not restrict egress.
Reconciliation installs the replacements before removing the six obsolete policies and updates the existing Gateway policy. The setting remains disabled by default. Unrelated policies, including policies managed by the delegated Ledger Operator, remain unchanged.
Updated the documentation, unit/controller tests, and Chainsaw fixtures. Gateway admin/metrics port 3080 is now accessible only from within the namespace unless another policy allows it. Cross-Stack calls through the destination Gateway remain possible, subject to authentication.
Validation:
go test ./internal/resources/... ./api/...passed.KUBEBUILDER_ASSETS=<local envtest assets> go test ./internal/tests -ginkgo.focus=NetworkPolicyController -ginkgo.no-colorpassed.git diff --checkpassed.Network enforcement and Chainsaw tests have not been run on Sandbox; local controller tests use envtest without a CNI.