Repository navigation
feat(auth): generate a signing key per stack - #554
Merged
Merged
Conversation
Use a persistent Secret for Auth instances without an explicit signing key so stacks do not share the service default key.
NumaryBot
added
risk: medium
NumaryBot
previously approved these changes
Oct 14, 2026
NumaryBot
left a comment
NumaryBot
left a comment
Contributor
There was a problem hiding this comment.
The required automated review completed with no remaining findings.
added 2 commits
October 14, 2026 23:40
The dirty CI check regenerated the Auth CRD descriptions from the updated API comments. Commit both generated copies so pre-commit leaves the worktree clean.
Version the operator and CRD charts together so the release can be upgraded with one Helm operation.
NumaryBot
removed
the
review-approved
Contributor
Author
|
The Dirty check failed with "Working tree is dirty after pre-commit" because the Auth CRD descriptions were regenerated but missing from the PR. Commit 456302c adds both generated CRD files. The full Nix |
NumaryBot
added
risk: high
review-approved
NumaryBot
approved these changes
Oct 14, 2026
NumaryBot
left a comment
NumaryBot
left a comment
Contributor
There was a problem hiding this comment.
The required automated review completed with no remaining findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth-signing-keySecret and reuse it across reconciliations.SIGNING_KEYand restart the Auth Deployment if the generated Secret changes.operatorandoperator-crdsHelm charts to 3.18.0, with the operator and utils image defaults set tov3.18.0, so one operator chart upgrade includes the matching CRDs and behavior.Upgrade impact
Existing Auth installations that use the service's built-in key will switch to a new key. JWTs signed with the old key will no longer validate after the Auth Deployment restarts; clients must request new tokens.
The 3.18.0 chart and image must be published before this can be applied from a chart registry.
Validation
KUBEBUILDER_ASSETS="$(setup-envtest use 1.32.0 -p path)" go test ./...passed.nix develop --extra-experimental-features 'nix-command flakes' --impure --command just pre-commitpassed, including lint, generated CRDs, Helm chart update, and Helm validation.