Download refactor (UI & Logic) - #95
Closed
ItsDark008 wants to merge 3 commits into
Closed
ItsDark008 wants to merge 3 commits into
ItsDark008 wants to merge 3 commits into
Conversation
- add SidebarDownloadStatus with progress, speed and phase, collapsing to a compact indicator - extract ProgressBar and CancelDownloadDialog for reuse - poll download progress once at app level instead of per view
Collaborator
Author
|
Superseded by #96.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ETag, and onlyresume when the response is a matching
206 Partial ContentETagacross resumed responses and clear it when a downloadrestarts from scratch, so a later resume is not rejected by a stale validator
SidebarDownloadStatuswith progress, speed and phase for the active job,plus resume, pause and cancel quick actions
downloads section
ProgressBarandCancelDownloadDialogand reuse them inDownloadsViewHomeViewrendered while downloads refresh in the backgroundWhy
Interrupted downloads restarted from zero whenever the server omitted
ETag,because a stored validator was required to resume. The sidebar also gave no
feedback about a running download unless the downloads page was open.
Review notes
DownloadsViewintostores/downloads.tsand starts duringbootstrap, so it now runs on every section while a download is active
ETag, resume with a changedETagand thecleared validator after a restart