Skip to content

feat: add gap handlers for flex and grid containers - #792

Draft
SmrutiSawant wants to merge 4 commits into
frappe:developfrom
SmrutiSawant:gaps
Draft

feat: add gap handlers for flex and grid containers#792
SmrutiSawant wants to merge 4 commits into
frappe:developfrom
SmrutiSawant:gaps

Conversation

@SmrutiSawant

Copy link
Copy Markdown
Collaborator

Add on-canvas gap handles

Flex and grid containers could only have gap changed from the Layout panel.
Padding and margin already have draggable on-canvas handles; this adds the
equivalent for gap.

Demo

Recording.2026-08-31.130737.mp4

@greptile-apps

greptile-apps Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The PR is not safe to merge until gap bands handle row-spanning grid items without losing row boundaries.

A row-spanning item can merge distinct visual rows during clustering, preventing the corresponding row-gap handle from rendering.

Files Needing Attention: frontend/src/components/GapHandler.vue

Prompt To Fix All With AI
### Issue 1
frontend/src/components/GapHandler.vue:172-179
**Row spans merge gap bands**

When a grid item spans multiple rows, `clusterLines` groups ordinary items from both rows through the spanning box, causing the row-gap handle between those rows to disappear.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (3): Last reviewed commit: "Merge branch 'develop' into gaps" | Re-trigger Greptile

Comment thread frontend/src/components/GapHandler.vue Outdated
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.06%. Comparing base (a8264b7) to head (e6b9906).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #792   +/-   ##
========================================
  Coverage    66.06%   66.06%           
========================================
  Files           93       93           
  Lines        10386    10386           
========================================
  Hits          6862     6862           
  Misses        3524     3524           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416

Copy link
Copy Markdown
Member

@mergify update

@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

update

✅ Branch has been successfully updated

Comment thread frontend/src/components/GapHandler.vue Outdated
@greptile-apps

greptile-apps Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Want your agent to iterate on Greptile's feedback? Try greploops.

@SmrutiSawant
SmrutiSawant marked this pull request as draft September 7, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants