Skip to content
This repository was archived by the owner on Oct 27, 2026. It is now read-only.

Update installation command for flow client - #109

Open
ernestoruiz89 wants to merge 1 commit into
frappe:developfrom
ernestoruiz89:patch-1
Open

ernestoruiz89 wants to merge 1 commit into
frappe:developfrom
ernestoruiz89:patch-1

Conversation

@ernestoruiz89

Copy link
Copy Markdown

No description provided.

@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change reaches only the README's installation instructions.

Fix the installation command before merging.

Reviews (1) · Last reviewed commit: "Update installation command for flow cli..." · Reviewed by Greptile

Comment thread README.md
cd $PATH_TO_YOUR_BENCH
bench get-app flow
bench --site site-name install-app flow
bench --site site-name install-app flow_client

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Installation names the wrong app

install-app flow_client does not match this app's package name or app_name, which are both flow. Users following this command cannot finish installing the app. Keep install-app flow, as CI does.

Suggested change
bench --site site-name install-app flow_client
bench --site site-name install-app flow

Knowledge Base Used: Frappe app integration

Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 122

Comment:
**Installation names the wrong app**

`install-app flow_client` does not match this app's package name or `app_name`, which are both `flow`. Users following this command cannot finish installing the app. Keep `install-app flow`, as CI does.

```suggestion
bench --site site-name install-app flow
```

**Knowledge Base Used:** [Frappe app integration](https://app.greptile.com/frappe/-/custom-context/knowledge-base/frappe/flow_client/-/docs/frappe-app-integration.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant