This repository was archived by the owner on Oct 27, 2026. It is now read-only.
Repository navigation
Update installation command for flow client - #109
Open
ernestoruiz89 wants to merge 1 commit into
Open
ernestoruiz89 wants to merge 1 commit into
ernestoruiz89 wants to merge 1 commit into
Conversation
Contributor
[Low impact] The change reaches only the README's installation instructions. Fix the installation command before merging. Reviews (1) · Last reviewed commit: "Update installation command for flow cli..." · Reviewed by Greptile |
| cd $PATH_TO_YOUR_BENCH | ||
| bench get-app flow | ||
| bench --site site-name install-app flow | ||
| bench --site site-name install-app flow_client |
Contributor
There was a problem hiding this comment.
Installation names the wrong app
install-app flow_client does not match this app's package name or app_name, which are both flow. Users following this command cannot finish installing the app. Keep install-app flow, as CI does.
Suggested change
| bench --site site-name install-app flow_client | |
| bench --site site-name install-app flow |
Knowledge Base Used: Frappe app integration
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 122
Comment:
**Installation names the wrong app**
`install-app flow_client` does not match this app's package name or `app_name`, which are both `flow`. Users following this command cannot finish installing the app. Keep `install-app flow`, as CI does.
```suggestion
bench --site site-name install-app flow
```
**Knowledge Base Used:** [Frappe app integration](https://app.greptile.com/frappe/-/custom-context/knowledge-base/frappe/flow_client/-/docs/frappe-app-integration.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.