Skip to content

fix: bound Similarity Explorer resource use - #29

Merged
frathe merged 3 commits into
mainfrom
codex/propose-fix-for-explorer-resource-limit-vulnerability
Sep 16, 2026
Merged

frathe merged 3 commits into
mainfrom
codex/propose-fix-for-explorer-resource-limit-vulnerability

Conversation

@frathe

@frathe frathe commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Explorer now exposes persisted limits under Settings -> Limits -> Similarity Explorer: 512 MB of serialized map data per update and 10,000 items by default. Exceeding either limit shows an error toast with that settings path. The toast wraps in narrow windows, and a limit failure preserves installed-model readiness for retry.

The item setting replaces the fixed 5,000-image ceiling and can be raised for the previously qualified 50,655-image library. Client and worker capture and enforce the same configured item limit. Map snapshots travel as metadata, individual items, hierarchy merges, and a final marker, so a collection no longer depends on fitting its entire map into a single 128 MiB event. Both peers enforce the configured aggregate serialized-data budget, and the UI receives only complete snapshots. The memory setting bounds map data, not total process RSS or native inference memory.

Validation:

  • Race tests passed for preferences, similarity transport, Settings, and the Explorer feature.
  • Focused viewer race regressions passed for Explorer, preference wiring, toasts, and overlay ordering.
  • Transport tests cover configured 50,655-item subprocess delivery, exact aggregate boundaries, truncated/malformed frames, and preserving limit errors after worker cleanup. The historical native inference/cache trial was not rerun.
  • Settings persistence, editable defaults, invalid-input handling, stale-error suppression, and readable narrow-window toasts are covered. Actual Settings and toast renderings were inspected.
  • make verify-build, translation/manual guards, Linux test-shard inventory, and GoLand inspections passed.
  • Linux/amd64 make golden exposed two outdated invalid-drop toast baselines. Both were visually inspected and refreshed; the complete E2E render suite then passed.
  • Complete local Docker verification requires a native Linux/amd64 daemon; this machine reports Linux/ARM64. GitHub CI provides the complete native platform checks.

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Qodana for Go

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@frathe
frathe marked this pull request as ready for review September 16, 2026 18:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T18:51:34.505926Z 27b4b6c Draft marked ready
🔒 Security Review Completed 2026-09-16T18:52:30.391520Z 27b4b6c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@frathe
frathe merged commit 459663d into main Sep 16, 2026
13 of 14 checks passed
@frathe
frathe deleted the codex/propose-fix-for-explorer-resource-limit-vulnerability branch September 16, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant