fix: bound Similarity Explorer resource use - #29
Merged
frathe merged 3 commits intoSep 16, 2026
Merged
Conversation
Qodana for GoIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
frathe
marked this pull request as ready for review
September 16, 2026 18:46
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frathe
deleted the
codex/propose-fix-for-explorer-resource-limit-vulnerability
branch
September 16, 2026 18:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explorer now exposes persisted limits under Settings -> Limits -> Similarity Explorer: 512 MB of serialized map data per update and 10,000 items by default. Exceeding either limit shows an error toast with that settings path. The toast wraps in narrow windows, and a limit failure preserves installed-model readiness for retry.
The item setting replaces the fixed 5,000-image ceiling and can be raised for the previously qualified 50,655-image library. Client and worker capture and enforce the same configured item limit. Map snapshots travel as metadata, individual items, hierarchy merges, and a final marker, so a collection no longer depends on fitting its entire map into a single 128 MiB event. Both peers enforce the configured aggregate serialized-data budget, and the UI receives only complete snapshots. The memory setting bounds map data, not total process RSS or native inference memory.
Validation:
make verify-build, translation/manual guards, Linux test-shard inventory, and GoLand inspections passed.make goldenexposed two outdated invalid-drop toast baselines. Both were visually inspected and refreshed; the complete E2E render suite then passed.