Pin SimplySign installer digest and signer - #30
Conversation
Qodana for GoIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
|
Removed the unused loopback server and corrected the local-installer documentation. The pinned action skips downloading when Validation: both focused release-workflow tests passed, YAML and installer-handoff structural checks passed, formatting and whitespace checks passed. GoLand reported only the pre-existing HTTP timestamp-URL weak warning. PR CI does not exercise the credentialed signing job. @codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Review loop completed for
The protected-environment pin configuration and a credentialed signed test-tag release remain explicit qualification steps in |
The Windows release workflow now requires a reviewed SHA-256 digest and Authenticode signer thumbprint for the SimplySign Desktop installer. Missing, malformed or mismatched pins stop the signing job before installation.
The pinned setup action installs the verified
SimplySignDesktop.msialready in the workspace and skips its download step. Its reserved.invalidfallback URL makes a missing local installer fail. The signing guide documents both protected-environment variables and this local-file handoff.Validation: focused release-workflow regressions in
scripts/msixstageandscripts/updaternotices, YAML parsing and installer-handoff structural checks, formatting, and whitespace checks. GoLand found only the existing HTTP timestamp-URL weak warning outside this change. PR CI does not execute the credentialed Windows signing job; a signed test-tag release remains an explicit qualification step in the guide andtodos.md.