Add REV support to stage 1B - #147
Conversation
github-actions
Bot
added
Curriculum material
|
🌐 Preview URL: https://pr-147.frcsoftware.pages.dev |
|
Please add this to the website feature guide as well |
|
Should the sync key be changed to something more general? I'd imagine we want the ctre/rev tabs to synchronize across the entire site, not just stage 1b (as the sync key you have now is for 1b) |
|
Oh, and exactly how to set this up, with code ready to copy paste, should be included on one of the contribution pages or in the readme or something. Not sure where off the top of my head |
There was a problem hiding this comment.
Can we move the tab sync functionality to a separate PR? It's agnostic of content and therefore not required in this PR.
There was a problem hiding this comment.
I feel like it would be more awkward to have another PR that only adds this one file, and doesn't use the constant itself. If you're need the chooser key for a PR you're working on, then sure
| @@ -72,13 +86,13 @@ The `feed()`, `intake()`, `outtake()` and `idle()` commands should be returned f | |||
|
|
|||
| </details> | |||
| <details class="accordion"> | |||
| <summary>Item 1, Hint 2</summary> | |||
| You can create a `CANBus` object via `CANBus.systemcore(id)`. | |||
| <summary>Item 1, Hint 2 (CTRE only)</summary> | |||
| For CTRE devices, a `CANBus` object can be created via `CANBus.systemcore(id)`. | |||
| </details> | |||
| {/* prettier-ignore */} | |||
| <details class="accordion"> | |||
| <summary>Item 1, Hint 3</summary> | |||
| Remember that `TalonFX` is a class, and that creating objects within another | |||
| Remember that `TalonFX` and `SparkMax` are classes, and that creating objects within another | |||
| class is done like so: <br /> | |||
| {/* rli:ignore */} | |||
| ```java | |||
There was a problem hiding this comment.
Would it be possible to make this section have a CTRE/REV tag since the hints are different based on if the students pick CTRE or REV
There was a problem hiding this comment.
Personally, I don't think its necessary since the only exclusive hint is hint 2 (it also might render weirdly, although i haven't tried it yet).
4 participants
Description
Adds REV support to the stage 1B docs, including a chooser between the different vendors for code snippets within the exercises.
Also adds references to the solution GitHub repos in the docs.
Meta
Merge checklist: