fix(mail): backport markdown generation and HTML rendering fixes to 3.1 - #1093
Merged
Conversation
Port friendsofhyperf/mail#4 (a74e75481785ddd86c92f853358ad68ad23a94bf) to the 3.1 component, with Pest regressions and matching documentation examples.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the mail generator and HTML rendering fixes from friendsofhyperf/mail#4 (
a74e75481785ddd86c92f853358ad68ad23a94bf) to 3.1. The main-branch counterpart is #1092.gen:mail --markdownpreviously selected the wrong stub and returned a boolean instead of a view name; it now generates a Markdown mailable with the derived view name.Content(htmlString: ...)previously failed strict parameter typing; the rendering pipeline now acceptsHtmlStringand view-engineHtmlablevalues.The two source files match the original fix. Adds 10 Pest regression cases for normal/Markdown generation, the short flag, nested names, custom stubs, direct HTML/text objects, rendering, and mailable delivery through
ArrayTransport. All 10 fail before the fix and pass after it. Updates the existing README and four locale pages with the flag semantics and pre-rendered HTML examples.Validation
Validated in an isolated worktree with fresh 3.1-compatible dependencies: PHP 8.2.31, Hyperf Devtool 3.1.66, Pest 2.36.1.
vendor/bin/pest --group mail,notification --compact: 101 passed, 294 assertions.composer analyse src/mail: passed, 48 files.composer test:types: passed, total type coverage 87.7%.git diff --check: passed.The full monorepo unit suite and PHP 8.1 runtime matrix were not run. This branch has no
docs:checkscript; documentation was checked directly. No dependency manifests or configuration values were changed.