Skip to content

fix(mail): backport markdown generation and HTML rendering fixes to 3.1 - #1093

Merged
huangdijia merged 2 commits into
3.1from
codex/3.1-mail-markdown-htmlstring
Sep 13, 2026
Merged

fix(mail): backport markdown generation and HTML rendering fixes to 3.1#1093
huangdijia merged 2 commits into
3.1from
codex/3.1-mail-markdown-htmlstring

Conversation

@huangdijia

Copy link
Copy Markdown
Contributor

Backports the mail generator and HTML rendering fixes from friendsofhyperf/mail#4 (a74e75481785ddd86c92f853358ad68ad23a94bf) to 3.1. The main-branch counterpart is #1092.

gen:mail --markdown previously selected the wrong stub and returned a boolean instead of a view name; it now generates a Markdown mailable with the derived view name. Content(htmlString: ...) previously failed strict parameter typing; the rendering pipeline now accepts HtmlString and view-engine Htmlable values.

The two source files match the original fix. Adds 10 Pest regression cases for normal/Markdown generation, the short flag, nested names, custom stubs, direct HTML/text objects, rendering, and mailable delivery through ArrayTransport. All 10 fail before the fix and pass after it. Updates the existing README and four locale pages with the flag semantics and pre-rendered HTML examples.

Validation

Validated in an isolated worktree with fresh 3.1-compatible dependencies: PHP 8.2.31, Hyperf Devtool 3.1.66, Pest 2.36.1.

  • vendor/bin/pest --group mail,notification --compact: 101 passed, 294 assertions.
  • composer analyse src/mail: passed, 48 files.
  • PHP CS Fixer dry run on the four changed PHP files: passed.
  • README and four locale pages: headings, Markdown fences, installation command and new example consistency checked; the new PHP example passes syntax validation.
  • composer test:types: passed, total type coverage 87.7%.
  • git diff --check: passed.

The full monorepo unit suite and PHP 8.1 runtime matrix were not run. This branch has no docs:check script; documentation was checked directly. No dependency manifests or configuration values were changed.

Port friendsofhyperf/mail#4 (a74e75481785ddd86c92f853358ad68ad23a94bf) to the 3.1 component, with Pest regressions and matching documentation examples.
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 8fc060e8-8b30-4a14-847d-77bc03dabc30

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@huangdijia
huangdijia merged commit 9820840 into 3.1 Sep 13, 2026
11 checks passed
@huangdijia
huangdijia deleted the codex/3.1-mail-markdown-htmlstring branch September 13, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant