Repository navigation
Fix cloud package artifact root layout - #189
Draft
valerymoskalenko wants to merge 1 commit into
Draft
valerymoskalenko wants to merge 1 commit into
valerymoskalenko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: validation required before merge
This is a preview implementation. Validate the generated package in CI and with PAC CLI before merging into the
developbranch.References: https://github.com/fscpscollaborative/fscps.ado/issues/1
Change
CloudDeployablePackagewrapper directory.TemplatePackage.dll,PackageAssets, and the package metadata are at the expected root.Validation completed
git diff --checkpassed.Validation still required
The full solution compile could not run on the development machine because the .NET Framework 4.5.2 reference assemblies are not installed. CI validation must compile the solution and exercise the cloud-package path before merge.
The hard-coded solution filenames reported in issue #1 are generated inside the bundled
Microsoft.PowerPlatform.VSShared.Util.dll; this preview addresses the extra archive-root nesting. Filename generation requires a follow-up change in the package-generation component if the binary cannot be replaced or configured.This implementation was generated with assistance from the GPT-5.6 Luna model.