Repository navigation
Conversation
It was a heading, a wrapped paragraph and a boxed code block with an icon button, which read as a different dialog dropped into this one. It now uses the ordinary rows and text buttons: Command-Line Tool (with Install Options), Install Command (with Copy), and when netscli is found, Agent Config with Copy Config and the JSON one click away under Show config. The link now opens through the allow-listed opener instead of an anchor the webview can't follow.
… CSV too reverse.rs rejected only control characters, and the desktop app's CSV escaping defused only those, while the CLI now treats bidi overrides and zero-width characters as unsafe as well (is_unsafe_for_display). Both use that set now, and testdata/csv-escape.json holds the CLI and the desktop app to four new cases.
…ll scripts and MCP bundles now check The verify command accepted release.yml's signature from any ref. It now names main (and release tags, for releases before 0.3.1), as install.sh does. SECURITY.md said the install scripts check no signature and the MCP bundles have none, both true until the release-pipeline change. The packaging checklist told you to publish the release by hand, which the new flow does itself.
Default concurrency is 256 and macOS's default soft RLIMIT_NOFILE is 256, so a full-concurrency scan could hit EMFILE and report the failed connects as filtered. PortScanner, UdpScanner and PingScanner now raise the soft limit once per process to min(10240, hard limit). The Unix test runs in CI; this machine cannot build the Linux target's C dependencies.
# Conflicts: # CHANGELOG.md
The desktop app is live in the Store (product XPFG556RR6B76Z). The install section's Windows desktop list gets a Microsoft Store row with the official badge, unmodified and served from this site so the browser does not call Microsoft: the light badge on the dark theme and the dark one on the light theme. README and the install guide link the listing too.
The fallback removal left no way to send a lookup anywhere but the system's DNS servers, which on some home routers refuse MX and TXT. A named server is the honest replacement: netscli dns --server <ip>, /dns ... --server <ip>, a Server field in the desktop DNS tool, and a server parameter on the MCP dns_lookup tool, which holds it to the same target policy as a scan. The desktop backend parses it before the operation starts, so a typo is an error rather than a lookup that silently goes to the system's servers. resolver_source reads "server" for these answers. The guard against a built-in public resolver now bans hickory's presets everywhere and public resolvers' addresses outside test files, instead of any ResolverConfig, which a user-named server needs.
Contributor
|
Site preview: https://pr-565.netscli-site-preview.pages.dev Built from e5ef422 with Production is unaffected: netscli.com is served from GitHub Pages via |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The leftovers from the audit that touched several branches, plus what you asked for since.
What changes for users
netscli dns --server <ip>,/dns ... --server <ip>in the TUI, a Server field in the desktop DNS tool, and aserverparameter on MCPdns_lookup.resolver_sourcesaysserverfor these answers.netscli dns netscli.com --record MX --server 1.1.1.1 --csvanswers withserver.is_unsafe_for_display).testdata/csv-escape.jsongains four cases that both exports must pass.mcp-serviceis no longer described as a way to run the MCP server.main, asinstall.shdoes.packaging/README.mddescribe the signing and release flow from Release pipeline: build into the draft and publish only when every file is there; pinned winget tooling; signed installs #557.Checked
cargo fmt --all --check.cargo clippy -D warningson netscli-core, netscli, netscli-mcp and netscli-gui.cargo test: netscli 125, netscli-mcp 51, core DNS tests, and the guard against a built-in public resolver.astro check, build,check:css.