Modify devcontainer.json for Ruby and Node features - #190
Closed
fulldecent wants to merge 1 commit into
Closed
Conversation
Updated devcontainer configuration to include Ruby LSP extension and improved post-create command.
There was a problem hiding this comment.
🟡 Changes recommended
The updated postCreateCommand calls rbenv install without specifying a Ruby version, which is likely to fail and break container setup.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the repository’s Dev Container configuration for a smoother Ruby + Node development experience when working on the Jekyll site locally.
Changes:
- Updates the Ruby/Node feature notes and refines the
postCreateCommandto use stricter shell settings and Corepack-based Yarn setup. - Adds the Ruby LSP VS Code extension to the default devcontainer extensions list.
- Forwards Jekyll and Live Reload ports and adds labels for them.
File summaries
| File | Description |
|---|---|
.devcontainer/devcontainer.json |
Updates devcontainer features, post-create setup steps, VS Code extensions, and forwarded ports for local development. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| }, | ||
| "postCreateCommand": "/bin/bash -c 'set -e; rbenv install --skip-existing; rbenv rehash; npm install -g corepack; corepack enable; corepack prepare yarn@4.18.0 --activate; yarn install --immutable; bundle install'", | ||
|
|
||
| "postCreateCommand": "bash -c 'set -euo pipefail; rbenv install --skip-existing; rbenv rehash; corepack enable; corepack prepare yarn@4.18.0 --activate; yarn install --immutable; bundle install'", |
Owner
Author
|
codespaces suck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated devcontainer configuration to include Ruby LSP extension and improved post-create command.