refactor(cloudformation): group template Mappings by concern to match funfair-treasury-reporting #435

Activity

1. credfeto

   added

   AI-WorkWork for an AI AgentWork for an AI Agent

   on Oct 29, 2026
2. dnyw4l3n13

   self-assigned this

   on Oct 31, 2026
3. dnyw4l3n13 commented on Oct 31, 2026

   

   dnyw4l3n13

   on Oct 31, 2026

   Collaborator

   More actions

   Implementation Plan

   Files to change

   • cloudformation.json - replace Mappings.Settings.Values with Mappings.Deployment.<Group>.<Key> and update all 33 Fn::FindInMap lookups
   • README.md - document the grouped Deployment mapping in the Deployment section
   • CHANGELOG.md - add an entry via the changelog tool

   Approach

   Split the flat block into groups, matching funfair-treasury-reporting where a key exists there:

   • Network: ClusterName (was ECSClusterName), SecurityGroupIds (string list), SubnetIds (string list), VpcId, plus VpcLinkEgressCidr.
   • Task: Cpu, Memory, ExecutionRole, ContainerOwner, SecretsManagerArn, ContainerPort.
   • Service: DesiredCount, MinimumHealthPercent, MaximumHealthPercent.
   • Settings: LogRetentionInDays.
   • LoadBalancer: ListenerArn, InternalAlbServerName.
   • BuildBot-only groups: ApiGateway (CertificateArn, ThrottlingBurstLimit, ThrottlingRateLimit) and Dns (HostedZoneName).
     The security group and subnet values become real string lists, so the Fn::Split wrappers around those lookups are removed (as the treasury template does). Every other lookup changes only its map name, group and key. Resolved values stay identical.

   Test strategy

   • Confirm the JSON parses and that every Fn::FindInMap resolves to an existing group and key.
   • Compare old and new resolved values (the comma-split lists must equal the new lists).
   • Run cfn-lint if available, and the existing dotnet build and tests to confirm nothing else reads the template.

   Assumptions

   a. The AI memory file named in the issue (memory/code-organisation.instructions.md) lives in funfair-treasury-reporting. BuildBot has no equivalent file, so only the README is updated.
   b. List-valued mapping entries work with Fn::FindInMap (the treasury template already relies on this).
   c. Group and key names for BuildBot-only settings (ApiGateway, Dns, and where VpcLinkEgressCidr and InternalAlbServerName sit) are my choice.

   Open questions

   Q1. BuildBot has no AI memory file to update. Should one be created (for example a "Template Settings" section)? I will proceed without creating one unless told otherwise.
4. dnyw4l3n13

   added

   BlockedBlocked by a dependency or external factorBlocked by a dependency or external factor

   on Oct 31, 2026