Repository navigation
ci: validate pull requests with flake checks - #37
Merged
Merged
Conversation
oakagent
reviewed
Oct 2, 2026
oakagent
reviewed
Oct 2, 2026
arminsabouri
requested changes
Oct 2, 2026
| with: | ||
| path: result | ||
| deploy: | ||
| if: github.event_name == 'push' |
Collaborator
There was a problem hiding this comment.
Why did this get removed?
Collaborator
There was a problem hiding this comment.
Did we need to change deployment at all for a flake check job?
Member
Author
There was a problem hiding this comment.
Why did this get removed?
it became dead code. this PR removes the pull_request trigger from pages.yml (PR validation moved to checks.yml), so it only runs on push to main and the condition is always true
Did we need to change deployment at all for a flake check job?
not strictly, but keeping the trigger would build the site twice per PR. deploy is unchanged
Collaborator
There was a problem hiding this comment.
Ah yes missed that. Thanks
arminsabouri
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use flake checks to validate pull requests and keep deployment focused on building and publishing the site
closes #36