Skip to content

Prepend extra compile args to user given list #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlambert03 merged 1 commit into from
Jul 26, 2026
Merged

Prepend extra compile args to user given list #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/witty/compile_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,22 +172,22 @@ def build_extra_objects(build_dir: Path) -> list[str]:
extra_compile_args = []
# Use MSVC style flag on Windows, GCC/Clang flags otherwise
if sys.platform == "win32":
extra_compile_args += [
extra_compile_args = [
"/std:c++17",
"/DNDEBUG",
"/DNB_COMPACT_ASSERTIONS",
"/O2",
"/EHsc",
]
] + extra_compile_args
else:
extra_compile_args += [
extra_compile_args = [
"-std=c++17",
"-fvisibility=hidden",
"-DNDEBUG",
"-DNB_COMPACT_ASSERTIONS",
"-fPIC",
"-O3",
]
] + extra_compile_args

return _compile_module(
source,
Expand Down
Loading