Skip to content

build: no upper bound on the Cython version - #17

Merged
tlambert03 merged 1 commit into
funkelab:mainfrom
tlambert03:relax-cython-cap
Sep 30, 2026
Merged

tlambert03 merged 1 commit into
funkelab:mainfrom
tlambert03:relax-cython-cap

Conversation

@tlambert03

Copy link
Copy Markdown
Member

Cython >= 3.0,<3.2 (since e62d6a6, without a stated reason) means that nothing that depends on witty can be installed next to Cython 3.2 or 3.3. For waterz, which is about to make witty a hard dependency, that would make pip install waterz cython fail for anyone on a current Cython.

Testing

  • witty's tests with Cython 3.3.0 on Python 3.10 and 3.14: 4 passed each.
  • waterz's tests (103, including its JIT path through witty) with this branch and Cython 3.3.0 on Python 3.13: all pass.
  • CI resolves the newest Cython, so it runs with 3.3.0 here.

🤖 Generated with Claude Code

The tests pass with Cython 3.3.0, and a cap keeps every package that depends
on witty from being installed next to a newer Cython.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.73%. Comparing base (d30f274) to head (0f0ad4c).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   92.94%   92.73%   -0.21%     
==========================================
  Files           2        2              
  Lines         170      179       +9     
==========================================
+ Hits          158      166       +8     
- Misses         12       13       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03
tlambert03 merged commit 50c529c into funkelab:main Sep 30, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants