Repository navigation
fix(harness): apply an edited max_turns to the scenario a run plays - #126
Closed
KarthikAvinashFI wants to merge 2 commits into
Closed
KarthikAvinashFI wants to merge 2 commits into
KarthikAvinashFI wants to merge 2 commits into
Conversation
Member
Author
|
Folded into #128. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A run lays the platform's current scenario edits over the sealed scenario document before playing it (
_with_scenario_editsinfi/alk/harness/call_runner.py). The overlay only takes the fields listed in_EDITABLE_FIELDS, andmax_turnswas not listed. So an edited turn budget reached the run's metadata but never the chat call that reads it.What changed
src/fi/alk/harness/call_runner.py_EDITABLE_FIELDSincludesmax_turns. Voice calls do not readmax_turns, so they are unaffected; chat calls (chat_call_runner._conversation_scenario) now use the edited value.tests/harness/test_scenario_edits.pymax_turns, plus a personalanguageslist with two entries.Tests
test_edits_replace_only_what_a_call_playsmax_turnsand a two-language persona are overlaid;testsandinstructionstay sealed.test_a_chat_caller_is_the_edited_personamax_turns.Verified live
Built into a hosted sandbox template with ALK
devand #128. The image carries_EDITABLE_FIELDS = ("background_noise", "max_turns"). An editedmax_turnsreaches the run'sscenario_editson a chat environment. Voice calls, which do not readmax_turns, completed on the new template across two fresh environments.How to run
Linear
Part of TH-7985