Repository navigation
fix(harness): import fi.simulate on the callback adapter's main thread - #147
Closed
KarthikAvinashFI wants to merge 1 commit into
Closed
KarthikAvinashFI wants to merge 1 commit into
KarthikAvinashFI wants to merge 1 commit into
Conversation
KarthikAvinashFI
marked this pull request as ready for review
October 9, 2026 04:42
Member
Author
|
Folded into #128. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every hosted chat run of a callback-style agent fails before the first turn with
target_agent_failed: Plugins must be registered on the main thread.The callback adapter imports
fi.simulateinside_invoke, which runs on aThreadingHTTPServerworker thread. With livekit installed, as in the hosted runtime image, that import registers livekit plugins, and livekit refuses registration off the main thread. Voice agents do not use this adapter and are unaffected.What changed
src/fi/alk/harness/callback_http_adapter.pyfrom fi.simulate import AgentInputmoves to module level, so it runs on the main thread at process start.tests/harness/test_callback_http_adapter.py/invoke. Fails before the fix when livekit is installed; passes after.Testing
devand passes on this branch, in an environment with thelivekitextra.tests/harness -k "bundle_author or callback or chat": 114 passed.ruff checkandruff format --checkclean.